[AMD Public Use] There are currently three instances of StandardSignatureIsAuthenticAMD Function in the below locations. I need to propose another change that will require the same function in PiSmmCpuDxeSmm. I would like to see this function move to a single "LibraryClass" location. I think no one knew where to propose the function, so we ended up with three instances so far. The best place I can find would be UefiCpuPkg/BaseUefiCpuLib/. Thoughts? Is there a better function name such that a similar Intel identifier function could be created when needed in the future?
I'm thinking this will be 3 patches 1. Add StandardSignatureIsAuthenticAMD to BaseUefiCpuLib 2. Move current instances to Library function 3. Propose code change in PiSmmCpuDxeSmm UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c: StandardSignatureIsAuthenticAMD ( UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c: StandardSignatureIsAuthenticAMD ( UefiCpuPkg/Library/MpInitLib/MpLib.c: StandardSignatureIsAuthenticAMD ( GARRETT KIRKENDALL SMTS Firmware Engineer | CTE 7171 Southwest Parkway, Austin, TX 78735 USA AMD facebook | amd.com -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61079): https://edk2.groups.io/g/devel/message/61079 Mute This Topic: https://groups.io/mt/74797268/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
