On 6/10/20 7:08 AM, Laszlo Ersek wrote: > Hi Tom, > > On 06/05/20 15:27, Tom Lendacky wrote: >> BZ: >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2198&data=02%7C01%7Cthomas.lendacky%40amd.com%7Cae12d2d0f5c94ee905c708d80d3711e6%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637273877466672474&sdata=SNfXYJYwNPKmYyWq5xNrIY7PWSbBZkLNWIQ%2B2vtJk3c%3D&reserved=0 >> >> Various CpuExceptionHandlerLib libraries will updated to use the new >> VmgExitLib library. To prevent any build breakage, update the OvmfPkg >> DSC files that use a form of the CpuExceptionHandlerLib library to >> include the VmgExitLib library. >> >> Cc: Jordan Justen <jordan.l.jus...@intel.com> >> Cc: Laszlo Ersek <ler...@redhat.com> >> Cc: Ard Biesheuvel <ard.biesheu...@arm.com> >> Cc: Anthony Perard <anthony.per...@citrix.com> >> Cc: Julien Grall <jul...@xen.org> >> Reviewed-by: Laszlo Ersek <ler...@redhat.com> >> Signed-off-by: Tom Lendacky <thomas.lenda...@amd.com> >> --- >> OvmfPkg/OvmfPkgIa32.dsc | 1 + >> OvmfPkg/OvmfPkgIa32X64.dsc | 1 + >> OvmfPkg/OvmfPkgX64.dsc | 1 + >> OvmfPkg/OvmfXen.dsc | 1 + >> 4 files changed, 4 insertions(+) > > not a code comment, but a process comment. > > I'm comparing this v9 series against v8, with git-range-diff. For the > comparison, I'm using your "sev-es-v16" branch (v8 on the list) versus > "sev-es-v17" (v9 on the list -- this series). > > For this patch, git-range-diff tells me: > > 9: 557f9c473fe6 ! 9: 63aae4b9cc75 OvmfPkg: Prepare OvmfPkg to use the > VmgExitLib library > @@ -11,7 +11,9 @@ > > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > - Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > + Cc: Ard Biesheuvel <ard.biesheu...@arm.com> > + Cc: Anthony Perard <anthony.per...@citrix.com> > + Cc: Julien Grall <jul...@xen.org> > Reviewed-by: Laszlo Ersek <ler...@redhat.com> > Signed-off-by: Tom Lendacky <thomas.lenda...@amd.com> > > meaning that you updated the CC list from v8 to v9. > > That's OK, in itself. > > However, if I look at the actual v8 message on-list: > > https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmid.mail-archive.com%2F2fd73ece7e6cfc0212b31646f4ea4bae6f6d51a8.1589925074.git.thomas.lendacky%40amd.com&data=02%7C01%7Cthomas.lendacky%40amd.com%7Cae12d2d0f5c94ee905c708d80d3711e6%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637273877466672474&sdata=qb6rUyivqq0kPKYUtGeTgcvlNUe8B8h7vKmeOZLvjK4%3D&reserved=0 > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F59865&data=02%7C01%7Cthomas.lendacky%40amd.com%7Cae12d2d0f5c94ee905c708d80d3711e6%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637273877466672474&sdata=mmZt3%2Fdc37OKtNaDoYGysZTut35BfKih0u3w2FrcFeI%3D&reserved=0 > > that shows that the v8 posting *already* included the longer CC list. > > The one explanation I can find for this is that you posted a different series > with subject prefix "v8" than the one pushed as branch "sev-es-v16". Is that > correct?
Looks like I made some final changes to the CC lists after re-running the get maintainers script and forgot to push that to github. Also missing from github is the final patch with the change to the maintainers list. Code-wise, though, everything is identical. > > Please do not introduce any changes between the pushed and the posted > versions. They must be *completely identical*. A miss on my end to do the final push to github before sending out the patches. I can do a force push for the sev-es-v16 branch to match what was submitted if that will help you (of course you'll have to reset your branch if I do that), your call. Thanks, Tom > > The on-list versions are the authoritative ones (that's where the series will > be applied from). We're using the pushed branches only as a convenience tool > for review. But if the on-list version differs from the pushed version, how > can I rely on the pushed version, for review?> > Thanks > Laszlo > > > >> >> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc >> index d0df9cbbfb2b..7d7297aa1cd8 100644 >> --- a/OvmfPkg/OvmfPkgIa32.dsc >> +++ b/OvmfPkg/OvmfPkgIa32.dsc >> @@ -228,6 +228,7 @@ [LibraryClasses] >> >> [LibraryClasses.common] >> BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf >> + VmgExitLib|UefiCpuPkg/Library/VmgExitLibNull/VmgExitLibNull.inf >> >> [LibraryClasses.common.SEC] >> TimerLib|OvmfPkg/Library/AcpiTimerLib/BaseRomAcpiTimerLib.inf >> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc >> index b3ae62fee92b..c85e988372ec 100644 >> --- a/OvmfPkg/OvmfPkgIa32X64.dsc >> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc >> @@ -232,6 +232,7 @@ [LibraryClasses] >> >> [LibraryClasses.common] >> BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf >> + VmgExitLib|UefiCpuPkg/Library/VmgExitLibNull/VmgExitLibNull.inf >> >> [LibraryClasses.common.SEC] >> TimerLib|OvmfPkg/Library/AcpiTimerLib/BaseRomAcpiTimerLib.inf >> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc >> index f7fe75ebf531..0b9189ab1e38 100644 >> --- a/OvmfPkg/OvmfPkgX64.dsc >> +++ b/OvmfPkg/OvmfPkgX64.dsc >> @@ -232,6 +232,7 @@ [LibraryClasses] >> >> [LibraryClasses.common] >> BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf >> + VmgExitLib|UefiCpuPkg/Library/VmgExitLibNull/VmgExitLibNull.inf >> >> [LibraryClasses.common.SEC] >> TimerLib|OvmfPkg/Library/AcpiTimerLib/BaseRomAcpiTimerLib.inf >> diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc >> index 3af0ee705407..a3ba96f7002a 100644 >> --- a/OvmfPkg/OvmfXen.dsc >> +++ b/OvmfPkg/OvmfXen.dsc >> @@ -213,6 +213,7 @@ [LibraryClasses] >> >> [LibraryClasses.common] >> BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf >> + VmgExitLib|UefiCpuPkg/Library/VmgExitLibNull/VmgExitLibNull.inf >> >> [LibraryClasses.common.SEC] >> QemuFwCfgLib|OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgSecLib.inf >> > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61078): https://edk2.groups.io/g/devel/message/61078 Mute This Topic: https://groups.io/mt/74692414/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
