On Fri, Jun 05, 2020 at 15:01:36 +0200, Ard Biesheuvel wrote:
> On 6/5/20 6:02 PM, Meenakshi Aggarwal wrote:
> > Enable support of SATA drives on lx2160 RDB board.
> >
> > Signed-off-by: Meenakshi Aggarwal <meenakshi.aggar...@nxp.com>
> > ---
> > Silicon/NXP/LX2160A/LX2160A.dsc.inc | 5 +++++
> > Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc | 2 ++
> > Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf | 18 +++++++++++++++---
> > 3 files changed, 22 insertions(+), 3 deletions(-)
> >
> > diff --git a/Silicon/NXP/LX2160A/LX2160A.dsc.inc
> > b/Silicon/NXP/LX2160A/LX2160A.dsc.inc
> > index 55dd3b5442eb..6bd08d527aed 100644
> > --- a/Silicon/NXP/LX2160A/LX2160A.dsc.inc
> > +++ b/Silicon/NXP/LX2160A/LX2160A.dsc.inc
> > @@ -40,8 +40,13 @@ [PcdsFixedAtBuild.common]
> > gNxpQoriqLsTokenSpaceGuid.PcdUsbSize|0x10000
> > gNxpQoriqLsTokenSpaceGuid.PcdNumUsbController|2
> > + gNxpQoriqLsTokenSpaceGuid.PcdSataBaseAddr|0x3200000
> > + gNxpQoriqLsTokenSpaceGuid.PcdSataSize|0x10000
> > + gNxpQoriqLsTokenSpaceGuid.PcdNumSataController|0x4
> > +
> > [PcdsFeatureFlag]
> > gNxpQoriqLsTokenSpaceGuid.PcdI2cErratumA009203|TRUE
> > + gNxpQoriqLsTokenSpaceGuid.PcdSataErratumA009185|TRUE
> >
> > ################################################################################
> > #
> > diff --git a/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc
> > b/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc
> > index ec27a1a219a5..2c65577eceab 100644
> > --- a/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc
> > +++ b/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc
> > @@ -44,4 +44,6 @@ [Components.common]
> > }
> > Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.inf
> > +
> > + Silicon/NXP/Drivers/SataInitDxe/SataInitDxe.inf
> > ##
> > diff --git a/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf
> > b/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf
> > index 5cb809e8b3a0..e8ac7658c011 100644
> > --- a/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf
> > +++ b/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf
> > @@ -23,10 +23,10 @@
> > [FD.LX2160ARDB_EFI]
> > BaseAddress = 0x82000000|gArmTokenSpaceGuid.PcdFdBaseAddress #The base
> > address of the FLASH Device.
> > -Size = 0x00160000|gArmTokenSpaceGuid.PcdFdSize #The size
> > in bytes of the FLASH Device
> > +Size = 0x00180000|gArmTokenSpaceGuid.PcdFdSize #The size
> > in bytes of the FLASH Device
> > ErasePolarity = 1
> > BlockSize = 0x10000
> > -NumBlocks = 0x16
> > +NumBlocks = 0x18
> >
> > ################################################################################
> > #
> > @@ -43,7 +43,7 @@ [FD.LX2160ARDB_EFI]
> > # RegionType <FV, DATA, or FILE>
> > #
> >
> > ################################################################################
> > -0x00000000|0x00160000
> > +0x00000000|0x00180000
> > gArmTokenSpaceGuid.PcdFvBaseAddress|gArmTokenSpaceGuid.PcdFvSize
> > FV = FVMAIN_COMPACT
>
> I don't mind these unrelated changes (but Leif might) but you should make a
> note of them in the commit log.
If the change is to accommodate the added drivers, they're not
unrelated. But yes, they should still be explicitly called out in
commit message.
/
Leif
> > @@ -132,6 +132,18 @@ [FV.FvMain]
> > INF MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf
> > INF Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.inf
> > +
> > + #
> > + # AHCI Support
> > + #
> > + INF MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
> > + INF MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
> > + INF MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf
> > + INF MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf
> > + INF MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf
> > +
> > + INF Silicon/NXP/Drivers/SataInitDxe/SataInitDxe.inf
> > +
> > #
> > # UEFI application (Shell Embedded Boot Loader)
> > #
> >
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#60768): https://edk2.groups.io/g/devel/message/60768
Mute This Topic: https://groups.io/mt/74690751/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
