REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606 As planed we will enable Ecc check for edk2 on open ci. And they are ready now, but these are V1 series. So I expect that contributors in edk2 community can try using this script when reviewing. And I hope receiving feedback and comments if someone find errors or false positive issues.
I created a pipline of EccCheck for my forked edk2. https://dev.azure.com/shengleizhang/shengleizhang/_build?definitionId=10&_a=summary Patches 1/5: This is a patch to enable python 3.8 for Ecc. It is a tool issues not a pipline or script issue. But it is listed here for people willing to try this tool. 2/5: EccCheck.py is a tool to report Ecc issues for commits. It can be run on azure servers for open ci, or locally. Its usage is like PatchCheck.py. 3/5: It's a lib necessary for py3 to run Ecc on azure servers. For local use, we need to type command "py -3 -m pip install antlr4-python3-runtime" first. 4/5: Windows-EccCheck.yml is a yaml file to configure the newly added pipline. The azure uses this to create a pipline. 5/5: We consider some cases that will report out Ecc issues but they won't be fixed, like submodule and industry standard related things. So we add two configuration fields "Exception" and "IgnoreFiles" for people to use. The patch is a example and the contents in the fields will be empty in final version. Note: For now this pipline can't report out Ecc issues like Tab character and trailing white spaceLine. And above issues are listed in CSV file after Ecc scanning traget files. But PatchCheck.py can report out them. I wonder whether we need to enable the above mentioned check points in this pipline, becaue either pipline fails, the commit will not be checked in. Cc: Bob Feng <bob.c.f...@intel.com> Cc: Bret Barkelew <bret.barke...@microsoft.com> Cc: Michael D Kinney <michael.d.kin...@intel.com> Cc: Liming Gao <liming....@intel.com> Cc: Sean Brogan <sean.bro...@microsoft.com> Fan, Zhiju (1): BaseTools:ECC needs to update the contents of CParser4 Shenglei Zhang (4): BaseTools/Scripts: Add EccCheck.py pip-requirements.txt: Add Ecc required lib .azurepiplines: Add a pipline to check ECC issues for commits MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration for Ecc check .azurepipelines/Windows-EccCheck.yml | 38 ++ BaseTools/Scripts/EccCheck.py | 426 ++++++++++++++++++ .../Source/Python/Ecc/CParser4/CLexer.py | 6 +- .../Source/Python/Ecc/CParser4/CListener.py | 4 +- .../Source/Python/Ecc/CParser4/CParser.py | 38 +- MdeModulePkg/MdeModulePkg.ci.yaml | 8 + pip-requirements.txt | 1 + 7 files changed, 498 insertions(+), 23 deletions(-) create mode 100644 .azurepipelines/Windows-EccCheck.yml create mode 100644 BaseTools/Scripts/EccCheck.py -- 2.18.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#60441): https://edk2.groups.io/g/devel/message/60441 Mute This Topic: https://groups.io/mt/74539806/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
