On Fri, May 22, 2020 at 14:42:34 +0200, Ard Biesheuvel wrote: > > > > > --- > > > > > The GCC support for this pragma has already been pulled into the 10.2 > > > > > release branch. I think we should consider adding this to the stable > > > > > tag, so that the issue can easily be resolved by upgrading the > > > > > compiler. > > > > > Whether we add the intrinsics too is a separate matter, but we can > > > > > revisit that later. > > > > > > > > Hmm. I am just slightly concerned over referencing GCC 10.2 before GCC > > > > 10.2 is released. > > > > Presumably, there will be no ill effects if that pragma is enabled also > > > > on 10.2, we just won't need it? If so ... > > > > > > > > > > No the pragma is only enabled on 10.2 and later. Older GCCs will choke on > > > it. > > > > Urgh, right. I guess I'm having a "can't read" day. > > > > Still. That means that if the pragma gets pulled last second from > > 10.2, we now explicitly break builds for 10.2. > > No matter how low the risk of that happening, this doesn't make me > > comfortable. > > Indeed. So assuming that we won't take the atomics patch for the stable tag, > we already know it will be broken for all GCC 10 and up.
Which isn't ideal, as we're seeing people picking that up. I think in a list of not great options I would probably prefer getting the intrinsics into the stable tag. / Leif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#60140): https://edk2.groups.io/g/devel/message/60140 Mute This Topic: https://groups.io/mt/74396053/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-