Reviewed-by: Chasel Chiu <chasel.c...@intel.com>
> -----Original Message----- > From: Vitaly Cheptsov <chept...@ispras.ru> > Sent: Wednesday, May 13, 2020 1:02 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel <chasel.c...@intel.com>; Desimone, Nathaniel L > <nathaniel.l.desim...@intel.com>; Zeng, Star <star.z...@intel.com> > Subject: [PATCH V5 14/27] IntelFsp2Pkg: Add support for DebugCommonLib > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 > > CC: Chasel Chiu <chasel.c...@intel.com> > CC: Nate DeSimone <nathaniel.l.desim...@intel.com> > CC: Star Zeng <star.z...@intel.com> > Signed-off-by: Vitaly Cheptsov <vit9...@protonmail.com> > --- > IntelFsp2Pkg/IntelFsp2Pkg.dsc > | 1 + > > IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSerialPort. > inf | 2 +- > IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c > | 97 -------------------- > 3 files changed, 2 insertions(+), 98 deletions(-) > > diff --git a/IntelFsp2Pkg/IntelFsp2Pkg.dsc b/IntelFsp2Pkg/IntelFsp2Pkg.dsc > index 02fe9cb188..3b2d2a5b8a 100644 > --- a/IntelFsp2Pkg/IntelFsp2Pkg.dsc > +++ b/IntelFsp2Pkg/IntelFsp2Pkg.dsc > @@ -21,6 +21,7 @@ [LibraryClasses] > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf+ > DebugCommonLib|MdePkg/Library/BaseDebugCommonLib/BaseDebugCom > monLib.inf > DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/Base > DebugPrintErrorLevelLib.inf > PciCf8Lib|MdePkg/Library/BasePciCf8Lib/BasePciCf8Lib.inf > IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.infdiff --git > a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSerialPo > rt.inf > b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSerialPo > rt.inf > index 14b1899e6c..9198118106 100644 > --- > a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSerialPo > rt.inf > +++ b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSeri > +++ alPort.inf > @@ -35,11 +35,11 @@ [LibraryClasses] > PcdLib PrintLib BaseLib+ DebugCommonLib DebugDeviceLib > DebugPrintErrorLevelLib [Pcd] > gEfiMdePkgTokenSpaceGuid.PcdDebugClearMemoryValue ## > CONSUMES gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask > ## CONSUMES- gEfiMdePkgTokenSpaceGuid.PcdFixedDebugPrintErrorLevel > ## CONSUMES diff --git > a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c > b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c > index b34905365d..f2e1de8822 100644 > --- a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c > +++ b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c > @@ -316,100 +316,3 @@ DebugClearMemory ( > { return Buffer; }---/**- Returns TRUE if ASSERT() macros are enabled.-- > This function returns TRUE if the > DEBUG_PROPERTY_DEBUG_ASSERT_ENABLED bit of- > PcdDebugPropertyMask is set. Otherwise FALSE is returned.-- @retval > TRUE The DEBUG_PROPERTY_DEBUG_ASSERT_ENABLED bit of > PcdDebugPropertyMask is set.- @retval FALSE The > DEBUG_PROPERTY_DEBUG_ASSERT_ENABLED bit of PcdDebugPropertyMask > is clear.--**/-BOOLEAN-EFIAPI-DebugAssertEnabled (- VOID- )-{- return > (BOOLEAN) ((PcdGet8(PcdDebugPropertyMask) & > DEBUG_PROPERTY_DEBUG_ASSERT_ENABLED) != 0);-}---/**- Returns TRUE > if DEBUG() macros are enabled.-- This function returns TRUE if the > DEBUG_PROPERTY_DEBUG_PRINT_ENABLED bit of- > PcdDebugPropertyMask is set. Otherwise FALSE is returned.-- @retval > TRUE The DEBUG_PROPERTY_DEBUG_PRINT_ENABLED bit of > PcdDebugPropertyMask is set.- @retval FALSE The > DEBUG_PROPERTY_DEBUG_PRINT_ENABLED bit of PcdDebugPropertyMask is > clear.--**/-BOOLEAN-EFIAPI-DebugPrintEnabled (- VOID- )-{- return > (BOOLEAN) ((PcdGet8(PcdDebugPropertyMask) & > DEBUG_PROPERTY_DEBUG_PRINT_ENABLED) != 0);-}--/**- Returns TRUE if > DEBUG_CODE() macros are enabled.-- This function returns TRUE if the > DEBUG_PROPERTY_DEBUG_CODE_ENABLED bit of- PcdDebugPropertyMask > is set. Otherwise FALSE is returned.-- @retval TRUE The > DEBUG_PROPERTY_DEBUG_CODE_ENABLED bit of PcdDebugPropertyMask is > set.- @retval FALSE The DEBUG_PROPERTY_DEBUG_CODE_ENABLED > bit of PcdDebugPropertyMask is > clear.--**/-BOOLEAN-EFIAPI-DebugCodeEnabled (- VOID- )-{- return > (BOOLEAN) ((PcdGet8(PcdDebugPropertyMask) & > DEBUG_PROPERTY_DEBUG_CODE_ENABLED) != 0);-}---/**- Returns TRUE if > DEBUG_CLEAR_MEMORY() macro is enabled.-- This function returns TRUE > if the DEBUG_PROPERTY_CLEAR_MEMORY_ENABLED bit of- > PcdDebugPropertyMask is set. Otherwise FALSE is returned.-- @retval > TRUE The DEBUG_PROPERTY_CLEAR_MEMORY_ENABLED bit of > PcdDebugPropertyMask is set.- @retval FALSE The > DEBUG_PROPERTY_CLEAR_MEMORY_ENABLED bit of > PcdDebugPropertyMask is > clear.--**/-BOOLEAN-EFIAPI-DebugClearMemoryEnabled (- VOID- )-{- > return (BOOLEAN) ((PcdGet8(PcdDebugPropertyMask) & > DEBUG_PROPERTY_CLEAR_MEMORY_ENABLED) != 0);-}--/**- Returns TRUE > if any one of the bit is set both in ErrorLevel and > PcdFixedDebugPrintErrorLevel.-- This function compares the bit mask of > ErrorLevel and PcdFixedDebugPrintErrorLevel.-- @retval TRUE > Current ErrorLevel is supported.- @retval FALSE Current ErrorLevel is > not supported.--**/-BOOLEAN-EFIAPI-DebugPrintLevelEnabled (- IN > CONST UINTN ErrorLevel- )-{- return (BOOLEAN) ((ErrorLevel & > PcdGet32(PcdFixedDebugPrintErrorLevel)) != 0);-}-- > 2.24.2 (Apple Git-127) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#59388): https://edk2.groups.io/g/devel/message/59388 Mute This Topic: https://groups.io/mt/74163299/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
