OK. I have no other comment. This patch set is good to me. Reviewed-by: Liming Gao <liming....@intel.com>
Thanks Liming > -----Original Message----- > From: Ard Biesheuvel <ard.biesheu...@arm.com> > Sent: Monday, May 11, 2020 10:10 PM > To: Gao, Liming <liming....@intel.com>; devel@edk2.groups.io > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Wang, Jian J > <jian.j.w...@intel.com>; Wu, Hao A <hao.a...@intel.com>; Leif > Lindholm <l...@nuviainc.com>; Sami Mujawar <sami.muja...@arm.com>; Yao, > Jiewen <jiewen....@intel.com> > Subject: Re: [edk2-devel] [PATCH resend 0/7] Add support for MM communicate2 > protocol (PI 1.7a) > > On 5/11/20 4:08 PM, Gao, Liming wrote: > > Ard: > > I see this change updates VariableSmmRuntimeDxe to consume > > mMmCommunication2 with mVariableBufferPhysical and > mVariableBuffer for physical and virtual. > > But, FaultTolerantWriteSmmDxe consumes mMmCommunication2 with the same > > SmmCommunicateHeader for physical and > virtual. > > > > Is there any difference between them? > > > > Yes. The FTW code never executes at runtime, so it is guaranteed that > physical == virtual. > > > >> -----Original Message----- > >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard > >> Biesheuvel > >> Sent: Thursday, May 7, 2020 1:27 AM > >> To: devel@edk2.groups.io > >> Cc: Ard Biesheuvel <ard.biesheu...@arm.com>; Kinney, Michael D > >> <michael.d.kin...@intel.com>; Gao, Liming > >> <liming....@intel.com>; Wang, Jian J <jian.j.w...@intel.com>; Wu, Hao A > >> <hao.a...@intel.com>; Leif Lindholm > >> <l...@nuviainc.com>; Sami Mujawar <sami.muja...@arm.com>; Yao, Jiewen > >> <jiewen....@intel.com> > >> Subject: [edk2-devel] [PATCH resend 0/7] Add support for MM communicate2 > >> protocol (PI 1.7a) > >> > >> Now that version 1.7 errata A of the PI spec has finally been released, > >> we can take another look at this series, which incorporates the new MM > >> communicate2 protocol definition, updates the producers for conventional > >> SMM and standalone MM, and updates the variable store components to consume > >> the new version of the protocol. This solves a long standing compatibility > >> issue which made standalone MM fundamentally incompatible with a virtually > >> remapped address space as installed by SetVirtualAddressMap(). > >> > >> Cc: Michael D Kinney <michael.d.kin...@intel.com> > >> Cc: Liming Gao <liming....@intel.com> > >> Cc: Jian J Wang <jian.j.w...@intel.com> > >> Cc: Hao A Wu <hao.a...@intel.com> > >> Cc: Leif Lindholm <l...@nuviainc.com> > >> Cc: Sami Mujawar <sami.muja...@arm.com> > >> Cc: Jiewen Yao <jiewen....@intel.com> > >> > >> Ard Biesheuvel (7): > >> MdePkg: introduce MM communicate 2 protocol > >> MdeModulePkg/SmmIpl: expose MM communicate 2 protocol > >> ArmPkg/MmCommunicationDxe: expose MM Communicate 2 protocol > >> MdeModulePkg/VariableInfo: switch to MM communicate 2 protocol > >> MdeModulePkg/FaultTolerantWriteSmmDxe: switch to MM communicate 2 > >> MdeModulePkg/VariableSmmRuntimeDxe: switch to MM communicate 2 > >> StandaloneMmPkg: switch to MM communicate 2 protocol > >> > >> .../MmCommunicationDxe/MmCommunication.c | 81 +++++++++---------- > >> .../MmCommunicationDxe/MmCommunication.inf | 6 +- > >> .../Application/VariableInfo/VariableInfo.c | 19 +++-- > >> .../Application/VariableInfo/VariableInfo.inf | 2 +- > >> MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c | 80 ++++++++++++++++++ > >> MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf | 1 + > >> MdeModulePkg/Include/Guid/SmmVariableCommon.h | 6 +- > >> .../FaultTolerantWriteSmmCommon.h | 2 +- > >> .../FaultTolerantWriteSmmDxe.c | 25 +++--- > >> .../FaultTolerantWriteSmmDxe.h | 2 +- > >> .../FaultTolerantWriteSmmDxe.inf | 4 +- > >> .../RuntimeDxe/VariableSmmRuntimeDxe.c | 39 ++++----- > >> .../RuntimeDxe/VariableSmmRuntimeDxe.inf | 4 +- > >> MdePkg/Include/Protocol/MmCommunication2.h | 69 ++++++++++++++++ > >> MdePkg/MdePkg.dec | 7 ++ > >> StandaloneMmPkg/Core/StandaloneMmCore.h | 2 +- > >> .../StandaloneMmCpu/AArch64/StandaloneMmCpu.h | 2 +- > >> 17 files changed, 256 insertions(+), 95 deletions(-) > >> create mode 100644 MdePkg/Include/Protocol/MmCommunication2.h > >> > >> -- > >> 2.17.1 > >> > >> > >> > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#59075): https://edk2.groups.io/g/devel/message/59075 Mute This Topic: https://groups.io/mt/74033563/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
