Robert,
I did similar change to MpService.h in
https://github.com/tianocore/edk2-staging/commit/2409b787fa196780e0fd101b2ad706575f82e2fc.
My plan was to move the change to edk2 once the spec is published.
It seems your change doesn't conflict with my change. More comments are added
in your change
which I think is better than mine.
A minor comment to the comment in below.
> +
> +/// Location2 The 6-level physical location of the processor, including the
> +/// physical package number that identifies the cartridge, the physical
> +/// module number within package, the physical tile number within the
> module,
> +/// the physical die number within the tile, the physical core number
> within
> +/// package, and logical thread number within core.
Can you move the above comment to the line before "Location2" field and remove
the "Location2 "? It aligns to existing comments style.
> +typedef union {
> + EFI_CPU_PHYSICAL_LOCATION2 Location2;
> +} EXTENDED_PROCESSOR_INFORMATION;
> +
> +
With that, Reviewed-by: Ray Ni <ray...@intel.com>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#59032): https://edk2.groups.io/g/devel/message/59032
Mute This Topic: https://groups.io/mt/74057701/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
