Re: [edk2-devel] [edk2-platforms][PATCH 1/1] RPi: add Gpio output set/clear functions to GpioLib

[Ard Biesheuvel]

On 5/10/20 11:36 PM, Andrei Warkentin wrote:
GpioSet and GpioClear. Using hw of course (not mailbox).
Signed-off-by: Andrei Warkentin <andrey.warken...@gmail.com>

Can you add this patch to the series that actually introduces a user for 
this new functionality?

Also, please don't hide unrelated changes in your patches like this.

---
  Silicon/Broadcom/Bcm283x/Include/Library/GpioLib.h | 10 +++++
  Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.c | 42 +++++++++++++++++++-
  2 files changed, 50 insertions(+), 2 deletions(-)

diff --git a/Silicon/Broadcom/Bcm283x/Include/Library/GpioLib.h 
b/Silicon/Broadcom/Bcm283x/Include/Library/GpioLib.h
index 014c6b07..10c9cdfb 100644
--- a/Silicon/Broadcom/Bcm283x/Include/Library/GpioLib.h
+++ b/Silicon/Broadcom/Bcm283x/Include/Library/GpioLib.h
@@ -24,4 +24,14 @@ GpioPinFuncGet (
    IN  UINTN Pin
    );
  
+VOID
+GpioSet (
+  IN  UINTN Pin
+  );
+
+VOID
+GpioClear (
+  IN  UINTN Pin
+  );
+
  #endif /* __GPIO_LIB__ */
diff --git a/Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.c 
b/Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.c
index 542b6e8f..716b05be 100644
--- a/Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.c
+++ b/Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.c
@@ -18,7 +18,7 @@
  
  STATIC
  VOID
-GpioFSELModify (
+GpioFSelModify (
    IN  UINTN RegIndex,
    IN  UINT32 ModifyMask,
    IN  UINT32 FunctionMask
@@ -38,6 +38,44 @@ GpioFSELModify (
    MmioWrite32 (Reg, Val);
  }
  
+VOID
+GpioSet (
+  IN  UINTN Pin
+  )
+{
+  UINT32 Val;
+  EFI_PHYSICAL_ADDRESS Reg;
+  UINT8 RegIndex = Pin / 32;
+  UINT8 SelIndex = Pin % 32;
+
+  Reg = RegIndex * sizeof (UINT32) + GPIO_GPSET0;
+
+  ASSERT (Reg <= GPIO_GPSET1);
+
+  Val = MmioRead32 (Reg);
+  Val |= 1 << SelIndex;
+  MmioWrite32 (Reg, Val);
+}
+
+VOID
+GpioClear (
+  IN  UINTN Pin
+  )
+{
+  UINT32 Val;
+  EFI_PHYSICAL_ADDRESS Reg;
+  UINT8 RegIndex = Pin / 32;
+  UINT8 SelIndex = Pin % 32;
+
+  Reg = RegIndex * sizeof (UINT32) + GPIO_GPCLR0;
+
+  ASSERT (Reg <= GPIO_GPCLR1);
+
+  Val = MmioRead32 (Reg);
+  Val |= 1 << SelIndex;
+  MmioWrite32 (Reg, Val);
+}
+
  VOID
  GpioPinFuncSet (
    IN  UINTN Pin,
@@ -57,7 +95,7 @@ GpioPinFuncSet (
  
    ModifyMask = GPIO_FSEL_MASK << (SelIndex * GPIO_FSEL_BITS_PER_PIN);
    FunctionMask = Function << (SelIndex * GPIO_FSEL_BITS_PER_PIN);
-  GpioFSELModify (RegIndex, ModifyMask, FunctionMask);
+  GpioFSelModify (RegIndex, ModifyMask, FunctionMask);
  }
  
  UINTN



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#59016): https://edk2.groups.io/g/devel/message/59016
Mute This Topic: https://groups.io/mt/74124217/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-