I think so - https://github.com/openbsd/src/blob/master/sys/dev/ic/bcmgenet.c#L427 (BSD licensed code, actually the UEFI driver's direct relative). Here you see if promisc is off, broadcast address is programmed into the filter as well.
And closer to UEFI reality, here's the Ax88772 driver from edk2-platform: https://github.com/tianocore/edk2-platforms/blob/94b23488bbda4361b6753adf6025c8a1dfabe27b/Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.c#L1081 In short, since we don't want to bother with filters now, let's enable promisc any time we're being asked for broadcast? A ________________________________ From: Ard Biesheuvel <ard.biesheu...@arm.com> Sent: Saturday, May 9, 2020 3:39 PM To: Andrei Warkentin <awarken...@vmware.com> Cc: devel@edk2.groups.io <devel@edk2.groups.io>; Pete Batard <p...@akeo.ie>; Jared McNeill <jmcne...@invisible.ca>; Samer El-Haj-Mahmoud <samer.el-haj-mahm...@arm.com> Subject: Re: [PATCH edk2-platforms 1/1] Silicon/Broadcom/BcmGenetDxe: fix multicast handling On 5/9/20 9:34 PM, Andrei Warkentin wrote: > Hi Ard, > > Could we upgrade broadcast to promisc? The spec allows using a “wider” filter. > Eh, are you sure the hardware needs the promiscuous mode enabled to receive broadcast frames? > Could we treat multicast the same way? So any non-unicast filter means > promisc? > The MNP layer already takes care of that. >> 9 мая 2020 г., в 6:06 AM, Ard Biesheuvel <ard.biesheu...@arm.com> написал(а): >> >> Move the handling of the promiscuous receive control to the SNP >> ReceiveFilters() method where it belongs. Given that we do not >> support multicast filtering, only minimal handling is required to >> test the promiscuous bit and program the MAC accordingly. Any >> multicast handling will be done by the MNP layer above it. >> >> Cc: Pete Batard <p...@akeo.ie> >> Cc: Jared McNeill <jmcne...@invisible.ca> >> Cc: Andrei Warkentin <awarken...@vmware.com> >> Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahm...@arm.com> >> Signed-off-by: Ard Biesheuvel <ard.biesheu...@arm.com> >> --- >> Silicon/Broadcom/Drivers/Net/BcmGenetDxe/DriverBinding.c | 7 +++---- >> Silicon/Broadcom/Drivers/Net/BcmGenetDxe/SimpleNetwork.c | 17 >> ++++++----------- >> 2 files changed, 9 insertions(+), 15 deletions(-) >> >> diff --git a/Silicon/Broadcom/Drivers/Net/BcmGenetDxe/DriverBinding.c >> b/Silicon/Broadcom/Drivers/Net/BcmGenetDxe/DriverBinding.c >> index e3d015dd0820..a6102421cc26 100644 >> --- a/Silicon/Broadcom/Drivers/Net/BcmGenetDxe/DriverBinding.c >> +++ b/Silicon/Broadcom/Drivers/Net/BcmGenetDxe/DriverBinding.c >> @@ -154,11 +154,10 @@ GenetDriverBindingStart ( >> Genet->SnpMode.NvRamSize = 0; >> Genet->SnpMode.NvRamAccessSize = 0; >> Genet->SnpMode.ReceiveFilterMask = >> EFI_SIMPLE_NETWORK_RECEIVE_UNICAST | >> - >> EFI_SIMPLE_NETWORK_RECEIVE_MULTICAST | >> >> EFI_SIMPLE_NETWORK_RECEIVE_BROADCAST | >> - >> EFI_SIMPLE_NETWORK_RECEIVE_PROMISCUOUS | >> - >> EFI_SIMPLE_NETWORK_RECEIVE_PROMISCUOUS_MULTICAST; >> - Genet->SnpMode.ReceiveFilterSetting = Genet->SnpMode.ReceiveFilterMask; >> + >> EFI_SIMPLE_NETWORK_RECEIVE_PROMISCUOUS; >> + Genet->SnpMode.ReceiveFilterSetting = >> EFI_SIMPLE_NETWORK_RECEIVE_UNICAST | >> + >> EFI_SIMPLE_NETWORK_RECEIVE_BROADCAST; >> Genet->SnpMode.MaxMCastFilterCount = 0; >> Genet->SnpMode.MCastFilterCount = 0; >> Genet->SnpMode.IfType = NET_IFTYPE_ETHERNET; >> diff --git a/Silicon/Broadcom/Drivers/Net/BcmGenetDxe/SimpleNetwork.c >> b/Silicon/Broadcom/Drivers/Net/BcmGenetDxe/SimpleNetwork.c >> index bf28448445d1..9ea153780538 100644 >> --- a/Silicon/Broadcom/Drivers/Net/BcmGenetDxe/SimpleNetwork.c >> +++ b/Silicon/Broadcom/Drivers/Net/BcmGenetDxe/SimpleNetwork.c >> @@ -148,10 +148,6 @@ GenetSimpleNetworkInitialize ( >> } >> >> GenetSetMacAddress (Genet, &Genet->SnpMode.CurrentAddress); >> - /* >> - * TODO: this belongs in GenetSimpleNetworkReceiveFilters, not here. >> - */ >> - GenetSetPromisc (Genet, TRUE); >> >> GenetDmaInitRings (Genet); >> >> @@ -306,6 +302,10 @@ GenetSimpleNetworkReceiveFilters ( >> } >> >> Genet = GENET_PRIVATE_DATA_FROM_SNP_THIS (This); >> + if (((Enable | Disable) & ~Genet->SnpMode.ReceiveFilterMask) != 0 || >> + (!ResetMCastFilter && MCastFilterCnt > >> Genet->SnpMode.MaxMCastFilterCount)) { >> + return EFI_INVALID_PARAMETER; >> + } >> if (Genet->SnpMode.State == EfiSimpleNetworkStopped) { >> return EFI_NOT_STARTED; >> } >> @@ -313,13 +313,8 @@ GenetSimpleNetworkReceiveFilters ( >> return EFI_DEVICE_ERROR; >> } >> >> - // >> - // Can't actually return EFI_UNSUPPORTED, so just ignore the filters >> - // (we set promiscuous mode ON inside GenetSimpleNetworkInitialize). >> - // >> - // TODO: move promisc handling here. >> - // TODO 2: support multicast/broadcast. >> - // >> + GenetSetPromisc (Genet, >> + (Enable & ~Disable & EFI_SIMPLE_NETWORK_RECEIVE_PROMISCUOUS) != 0); >> >> return EFI_SUCCESS; >> } >> -- >> 2.17.1 >> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#58980): https://edk2.groups.io/g/devel/message/58980 Mute This Topic: https://groups.io/mt/74093152/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
