Hi Guomin, Where are the typos? Please point out all the typos you found; it makes easy for Zhichao to fix all the typos.
Thanks, Eric From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Guomin Jiang Sent: Friday, May 8, 2020 3:24 PM To: devel@edk2.groups.io; Gao, Zhichao <zhichao....@intel.com> Cc: Wang, Jian J <jian.j.w...@intel.com>; Lu, XiaoyuX <xiaoyux...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com>; Yao, Jiewen <jiewen....@intel.com> Subject: Re: [edk2-devel] [PATCH V3 0/8] CryptoPkg: Retire the deprecated functions It seem ok except some typo, please modify it. Reviewed-by: Guomin Jiang <guomin.ji...@intel.com<mailto:guomin.ji...@intel.com>> > -----Original Message----- > From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> > <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Gao, > Zhichao > Sent: Thursday, May 7, 2020 7:58 AM > To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> > Cc: Wang, Jian J <jian.j.w...@intel.com<mailto:jian.j.w...@intel.com>>; Lu, > XiaoyuX <xiaoyux...@intel.com<mailto:xiaoyux...@intel.com>>; > Fu, Siyuan <siyuan...@intel.com<mailto:siyuan...@intel.com>>; Kinney, Michael > D > <michael.d.kin...@intel.com<mailto:michael.d.kin...@intel.com>>; Yao, Jiewen > <jiewen....@intel.com<mailto:jiewen....@intel.com>> > Subject: [edk2-devel] [PATCH V3 0/8] CryptoPkg: Retire the deprecated > functions > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 > > Retire below deprecated functions: > MD4, ARC4, TDES, AES ECB MODE, HMAC MD5, HMAC SHA1. > > V2: > Seprate the MD5 and SHA1 changes to other patch set. > Change the deprecated function wrapper implementatuion in > EDKII_CRYPTO_PROTOCOL to call a dummy function to print debug message > and assert. > > V3: > Remove the missing part of deprecated functions in V2. > Change the name field in the EDKII_CRYPTO_PROTOCOL to indicate the > function is deprecated and unsupported. > > Cc: Jian J Wang <jian.j.w...@intel.com<mailto:jian.j.w...@intel.com>> > Cc: Xiaoyu Lu <xiaoyux...@intel.com<mailto:xiaoyux...@intel.com>> > Cc: Siyuan Fu <siyuan...@intel.com<mailto:siyuan...@intel.com>> > Cc: Michael D Kinney > <michael.d.kin...@intel.com<mailto:michael.d.kin...@intel.com>> > Cc: Jiewen Yao <jiewen....@intel.com<mailto:jiewen....@intel.com>> > Signed-off-by: Zhichao Gao > <zhichao....@intel.com<mailto:zhichao....@intel.com>> > > Zhichao Gao (8): > CryptoPkg/CryptoDxe: Add function to indicate the deprecated algorithm > CryptoPkg/BaseCrpytLib: Retire MD4 algorithm > CryptoPkg/BaseCryptLib: Retire ARC4 algorithm > CryptoPkg/BaseCryptLib: Retire the Tdes algorithm > CryptoPkg/BaseCryptLib: Retire Aes Ecb mode algorithm > CryptoPkg/BaseCryptLib: Retire HMAC MD5 algorithm > CryptoPkg/BaseCryptLib: Retire HMAC SHA1 algorithm > CryptoPkg/Crypto.h: Update the version of Crypto Driver > > CryptoPkg/CryptoPkg.dsc | 46 +- > CryptoPkg/Driver/Crypto.c | 780 ++--------- > CryptoPkg/Include/Library/BaseCryptLib.h | 809 ------------ > .../Library/BaseCryptLib/BaseCryptLib.inf | 7 +- > .../Library/BaseCryptLib/Cipher/CryptAes.c | 114 -- > .../BaseCryptLib/Cipher/CryptAesNull.c | 52 - > .../Library/BaseCryptLib/Cipher/CryptArc4.c | 205 --- > .../BaseCryptLib/Cipher/CryptArc4Null.c | 124 -- > .../Library/BaseCryptLib/Cipher/CryptTdes.c | 364 ------ > .../BaseCryptLib/Cipher/CryptTdesNull.c | 160 --- > .../Library/BaseCryptLib/Hash/CryptMd4.c | 223 ---- > .../Library/BaseCryptLib/Hash/CryptMd4Null.c | 143 -- > .../Library/BaseCryptLib/Hmac/CryptHmacMd5.c | 216 --- > .../BaseCryptLib/Hmac/CryptHmacMd5Null.c | 139 -- > .../Library/BaseCryptLib/Hmac/CryptHmacSha1.c | 216 --- > .../BaseCryptLib/Hmac/CryptHmacSha1Null.c | 139 -- > .../Library/BaseCryptLib/PeiCryptLib.inf | 11 +- > .../Library/BaseCryptLib/PeiCryptLib.uni | 4 +- > CryptoPkg/Library/BaseCryptLib/Pem/CryptPem.c | 7 +- > .../Library/BaseCryptLib/RuntimeCryptLib.inf | 11 +- > .../Library/BaseCryptLib/RuntimeCryptLib.uni | 4 +- > .../Library/BaseCryptLib/SmmCryptLib.inf | 12 +- > .../Library/BaseCryptLib/SmmCryptLib.uni | 4 +- > .../BaseCryptLibNull/BaseCryptLibNull.inf | 5 - > .../BaseCryptLibNull/Cipher/CryptAesNull.c | 52 - > .../BaseCryptLibNull/Cipher/CryptArc4Null.c | 124 -- > .../BaseCryptLibNull/Cipher/CryptTdesNull.c | 160 --- > .../BaseCryptLibNull/Hash/CryptMd4Null.c | 143 -- > .../BaseCryptLibNull/Hmac/CryptHmacMd5Null.c | 139 -- > .../BaseCryptLibNull/Hmac/CryptHmacSha1Null.c | 139 -- > .../BaseCryptLibOnProtocolPpi/CryptLib.c | 1157 ++--------------- > .../Library/Include/openssl/opensslconf.h | 9 + > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 28 - > .../Library/OpensslLib/OpensslLibCrypto.inf | 28 - > CryptoPkg/Private/Protocol/Crypto.h | 708 ++-------- > 35 files changed, 389 insertions(+), 6093 deletions(-) delete mode 100644 > CryptoPkg/Library/BaseCryptLib/Cipher/CryptArc4.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLib/Cipher/CryptArc4Null.c > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Cipher/CryptTdes.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLib/Cipher/CryptTdesNull.c > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Hash/CryptMd4.c > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Hash/CryptMd4Null.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacMd5.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacMd5Null.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha1.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha1Null.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLibNull/Cipher/CryptArc4Null.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLibNull/Cipher/CryptTdesNull.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLibNull/Hash/CryptMd4Null.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLibNull/Hmac/CryptHmacMd5Null.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLibNull/Hmac/CryptHmacSha1Null.c > > -- > 2.21.0.windows.1 > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#58844): https://edk2.groups.io/g/devel/message/58844 Mute This Topic: https://groups.io/mt/74041185/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
