Hi Laszlo, Thanks for the reminder, I'll be more careful about the patch review.
Since this patch set early version cause build failure, my focus was mainly on the code. Thanks, Bob -----Original Message----- From: Laszlo Ersek <ler...@redhat.com> Sent: Wednesday, April 29, 2020 6:15 PM To: abner.ch...@hpe.com; Feng, Bob C <bob.c.f...@intel.com> Cc: devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH v4 0/3] BaseTools: BaseTools changes for RISC-V platform Hi Abner, Bob, On 04/23/20 15:52, Abner Chang wrote: > BZ for entire RISC-V edk2 port, > https://bugzilla.tianocore.org/show_bug.cgi?id=2672 > > These commits are verified by below PR, > https://github.com/tianocore/edk2/pull/512 > > In v4, GCC5_ASM_FLAGS is replaced by GCC5_RISCV64_ASM_FLAGS in > tools_def.template in 3/3 patch. > > Abner Chang (3): > BaseTools: BaseTools changes for RISC-V platform. > BaseTools: BaseTools changes for RISC-V platform. > BaseTools: BaseTools changes for RISC-V platform. Please don't write patch subjects like this. If I look at the git commit history now (just the subject lines), I see: $ git log --oneline --reverse cdc3fa54184a..f60d5ca97f25 ad1db975c0ca BaseTools: BaseTools changes for RISC-V platform. 178938b2b9b4 BaseTools: BaseTools changes for RISC-V platform. f60d5ca97f25 BaseTools: BaseTools changes for RISC-V platform. These subjects are nearly useless, especially three of them grouped together. The following would have been better (trivially composed from the bodies of the commit messages): BaseTools: C code changes for building EDK2 RISC-V platform BaseTools: Tools def. template updates for building EDK2 RISC-V platform BaseTools: Python code changes for building EDK2 RISC-V platform Bob: please remember that it's reviewer / maintainer responsibility as well to maintain a high level of commit message quality. The git commit history is relevant to the entire community, not just BaseTools owners. Thanks Laszlo > > BaseTools/Source/C/Common/PeCoffLib.h | 9 + > BaseTools/Source/C/GenFw/elf_common.h | 62 ++++ > .../C/Include/IndustryStandard/PeImage.h | 6 + > BaseTools/Source/C/Common/BasePeCoff.c | 15 +- > BaseTools/Source/C/Common/PeCoffLoaderEx.c | 86 ++++++ > BaseTools/Source/C/GenFv/GenFvInternalLib.c | 128 +++++++- > BaseTools/Source/C/GenFw/Elf32Convert.c | 5 +- > BaseTools/Source/C/GenFw/Elf64Convert.c | 282 +++++++++++++++++- > BaseTools/Conf/tools_def.template | 53 +++- > BaseTools/Source/Python/Common/DataType.py | 5 +- > BaseTools/Source/Python/build/buildoptions.py | 6 +- > 11 files changed, 638 insertions(+), 19 deletions(-) > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#58300): https://edk2.groups.io/g/devel/message/58300 Mute This Topic: https://groups.io/mt/73219115/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
