On 04/27/20 10:56, Philippe Mathieu-Daudé wrote: > On 4/25/20 12:17 AM, Rebecca Cran wrote: >> Signed-off-by: Rebecca Cran <rebe...@bsdio.com> >> Cc: Jordan Justen <jordan.l.jus...@intel.com> >> Cc: Laszlo Ersek <ler...@redhat.com> >> Cc: Ard Biesheuvel <ard.biesheu...@arm.com> >> --- >> OvmfPkg/AcpiPlatformDxe/EntryPoint.c | 8 +- >> OvmfPkg/AcpiPlatformDxe/PciDecoding.c | 10 +-- >> OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c | 32 ++++---- >> OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.c | 16 ++-- >> OvmfPkg/Csm/CsmSupportLib/LegacyInterrupt.c | 2 +- >> OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c | 2 +- >> OvmfPkg/Csm/CsmSupportLib/LegacyRegion.c | 2 +- >> OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c | 18 ++--- >> OvmfPkg/Csm/LegacyBiosDxe/LegacyBootSupport.c | 80 +++++++++---------- >> OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c | 62 +++++++------- >> OvmfPkg/Csm/LegacyBiosDxe/LegacySio.c | 2 +- >> OvmfPkg/Csm/LegacyBiosDxe/Thunk.c | 2 +- >> .../LegacyBootMaintUiLib/LegacyBootMaintUi.c | 2 +- >> OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c | 6 +- >> OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.c | 16 ++-- >> .../IncompatiblePciDeviceSupport.c | 2 +- >> .../Library/AcpiTimerLib/BaseAcpiTimerLib.c | 2 +- >> .../AcpiTimerLib/BaseRomAcpiTimerLib.c | 4 +- >> .../Library/AcpiTimerLib/DxeAcpiTimerLib.c | 2 +- >> OvmfPkg/Library/LoadLinuxLib/Linux.c | 8 +- >> OvmfPkg/Library/NvVarsFileLib/FsAccess.c | 16 ++-- >> .../PciHostBridgeLib/PciHostBridgeLib.c | 18 ++--- >> .../PlatformBootManagerLib/BdsPlatform.c | 30 +++---- >> OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxe.c | 6 +- >> OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c | 2 +- >> OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgPei.c | 6 +- >> OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgSec.c | 8 +- >> .../SerializeVariablesLib.c | 2 +- >> .../SmbiosVersionLib/DetectSmbiosVersionLib.c | 4 +- >> .../VirtioMmioDeviceLib/VirtioMmioDevice.c | 2 +- >> .../Library/XenHypercallLib/XenHypercall.c | 2 +- >> OvmfPkg/Library/XenIoMmioLib/XenIoMmioLib.c | 4 +- >> OvmfPkg/PlatformDxe/Platform.c | 6 +- >> OvmfPkg/PlatformPei/FeatureControl.c | 4 +- >> OvmfPkg/PlatformPei/Fv.c | 2 +- >> OvmfPkg/PlatformPei/MemDetect.c | 10 +-- >> OvmfPkg/PlatformPei/Platform.c | 22 ++--- >> OvmfPkg/PlatformPei/Xen.c | 4 +- >> .../FwBlockService.c | 10 +-- >> .../FwBlockServiceDxe.c | 4 +- >> .../FwBlockServiceSmm.c | 2 +- >> .../QemuFlash.c | 14 ++-- >> OvmfPkg/QemuVideoDxe/Driver.c | 10 +-- >> OvmfPkg/QemuVideoDxe/Gop.c | 4 +- >> OvmfPkg/QemuVideoDxe/Initialize.c | 8 +- >> OvmfPkg/QemuVideoDxe/VbeShim.c | 4 +- >> OvmfPkg/SataControllerDxe/SataController.c | 12 +-- >> OvmfPkg/Sec/SecMain.c | 22 ++--- >> OvmfPkg/SmmAccess/SmmAccessPei.c | 4 +- >> OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.c | 16 ++-- >> OvmfPkg/VirtioGpuDxe/Commands.c | 8 +- >> OvmfPkg/VirtioGpuDxe/DriverBinding.c | 8 +- >> OvmfPkg/VirtioGpuDxe/VirtioGpu.h | 2 +- >> OvmfPkg/XenBusDxe/EventChannel.c | 2 +- >> OvmfPkg/XenBusDxe/GrantTable.c | 8 +- >> OvmfPkg/XenBusDxe/XenBus.c | 14 ++-- >> OvmfPkg/XenBusDxe/XenBusDxe.c | 4 +- >> OvmfPkg/XenBusDxe/XenStore.c | 28 +++---- >> OvmfPkg/XenIoPciDxe/XenIoPciDxe.c | 2 +- >> OvmfPkg/XenPvBlkDxe/BlockFront.c | 50 ++++++------ >> OvmfPkg/XenPvBlkDxe/BlockIo.c | 6 +- >> OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.c | 2 +- >> 62 files changed, 335 insertions(+), 335 deletions(-) > > Reviewed-by: Philippe Mathieu-Daude <phi...@redhat.com> >
Thanks Phil, I will take your word on this one. I was ready to reject this patch, in this "unstructured dump" form, but I trust your review. Hence: Acked-by: Laszlo Ersek <ler...@redhat.com> Rebecca: thanks for the contribution. Personally I'd have preferred a finer-grained approach here, but Phil removed the review burden on me. Regarding the git history, edk2 unfortunately alreay carries a bunch of similarly large (even huge) coding style update patches, so I I can't hold that perspective against the patch. Thanks, Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#58238): https://edk2.groups.io/g/devel/message/58238 Mute This Topic: https://groups.io/mt/73252627/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
