Jiewen, Do you mean remove the definition of the deprecated function and keep the NULL value in the protocol structure? I am not sure if that is a good idea. Because that would give the protocol a chance to call a NULL pointer.
Siyuan, The binary would be totally different. Does that make sence? Thanks, Zhichao > -----Original Message----- > From: Yao, Jiewen > Sent: Saturday, April 25, 2020 9:48 PM > To: Fu, Siyuan <siyuan...@intel.com>; Gao, Zhichao <zhichao....@intel.com>; > devel@edk2.groups.io > Cc: Wang, Jian J <jian.j.w...@intel.com>; Lu, XiaoyuX <xiaoyux...@intel.com>; > Kinney, Michael D <michael.d.kin...@intel.com>; Laszlo Ersek > <ler...@redhat.com> > Subject: RE: [PATCH V2 7/7] CryptoPkg/Crypto.h: Update the version of Crypto > Driver > > Why not remove the deprecated functions ? > > Thank you > Yao Jiewen > > > -----Original Message----- > > From: Fu, Siyuan <siyuan...@intel.com> > > Sent: Saturday, April 25, 2020 5:45 PM > > To: Gao, Zhichao <zhichao....@intel.com>; devel@edk2.groups.io > > Cc: Wang, Jian J <jian.j.w...@intel.com>; Lu, XiaoyuX > > <xiaoyux...@intel.com>; Kinney, Michael D > > <michael.d.kin...@intel.com>; Yao, Jiewen <jiewen....@intel.com>; > > Laszlo Ersek <ler...@redhat.com> > > Subject: RE: [PATCH V2 7/7] CryptoPkg/Crypto.h: Update the version of > > Crypto Driver > > > > Hi, Zhichao > > > > This patch set doesn't add or remove any field in EDK II Crypto > > Protocol, but just change some API implementation to return false or > > unsupport, right? If so I don't think the Crypto Version need to be > > increased. > > > > Best Regards > > Siyuan > > > > > -----Original Message----- > > > From: Gao, Zhichao <zhichao....@intel.com> > > > Sent: 2020年4月23日 16:46 > > > To: devel@edk2.groups.io > > > Cc: Wang, Jian J <jian.j.w...@intel.com>; Lu, XiaoyuX > > > <xiaoyux...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; Kinney, > > > Michael D <michael.d.kin...@intel.com>; Yao, Jiewen > > > <jiewen....@intel.com>; Laszlo Ersek <ler...@redhat.com> > > > Subject: [PATCH V2 7/7] CryptoPkg/Crypto.h: Update the version of > > > Crypto Driver > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 > > > > > > Update the Crypto Version to 7: > > > 1. Retire below deprecated functions: > > > MD4, ARC4, TDES, AES ECB MODE, HMAC MD5, HMAC SHA1 > > > > > > Cc: Jian J Wang <jian.j.w...@intel.com> > > > Cc: Xiaoyu Lu <xiaoyux...@intel.com> > > > Cc: Siyuan Fu <siyuan...@intel.com> > > > Cc: Michael D Kinney <michael.d.kin...@intel.com> > > > Cc: Jiewen Yao <jiewen....@intel.com> > > > Cc: Laszlo Ersek <ler...@redhat.com> > > > Signed-off-by: Zhichao Gao <zhichao....@intel.com> > > > --- > > > CryptoPkg/Private/Protocol/Crypto.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/CryptoPkg/Private/Protocol/Crypto.h > > > b/CryptoPkg/Private/Protocol/Crypto.h > > > index 40c387e002..667ca1ef07 100644 > > > --- a/CryptoPkg/Private/Protocol/Crypto.h > > > +++ b/CryptoPkg/Private/Protocol/Crypto.h > > > @@ -20,7 +20,7 @@ > > > /// the EDK II Crypto Protocol is extended, this version define > > > must be /// increased. > > > /// > > > -#define EDKII_CRYPTO_VERSION 6 > > > +#define EDKII_CRYPTO_VERSION 7 > > > > > > /// > > > /// EDK II Crypto Protocol forward declaration > > > -- > > > 2.21.0.windows.1 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#58138): https://edk2.groups.io/g/devel/message/58138 Mute This Topic: https://groups.io/mt/73214653/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
