On 04/17/20 08:46, Rebecca Cran wrote: >> (2) Regarding platform code correctness, if someone from the bhyve >> community can help you and review your code, that's welcome. We've had >> fruitful examples for such collaboration, between xen-devel and >> edk2-devel subscribers. But, I won't really "insist" on this -- I just >> propose it. > > Peter Grehan, who's agreed to be the reviewer for BhyvePkg, has already > reviewed the changes.
That's awesome! It would be great if Peter could post formal R-b's or A-b's in response to (some of) the patches on edk2-devel. Alternatively, you could mention Peter's review somewhere in the commit messages, in natural language. Again, not a "hard requirement" from my side, I'd just really appreciate it. > >> If you must (or want to) stick with the 2-clause BSDL, then please list >> the components with that license in "Readme.md", near the existent >> "exceptions". > > Unfortunately it's not going to be possible to contact all the original > authors who contributed to BhyvePkg, so we'll need to stick with > 2-clause BSDL. OK! 2-clause BSDL is fine, per "Readme.md": """ 4. It is preferred that contributions are submitted using the same copyright license as the base project. When that is not possible, then contributions using the following licenses can be accepted: * BSD (2-clause): http://opensource.org/licenses/BSD-2-Clause """ Just please use the SPDX identifier format for the 2-clause BSDL, and also list the (partially) covered subdirs in "# License Details", in the Readme.md file. >> So, regarding these two modules, please do create copies of them under >> BhyvePkg, add the bhyve special sauce there, and eliminate everything >> from them that you do not need on bhyve. > > Perfect! Peter had concerns about the added complexity of those modules, > so it'll be good to have versions that are specific to bhyve. I'm relieved to hear this :) Thanks! Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57609): https://edk2.groups.io/g/devel/message/57609 Mute This Topic: https://groups.io/mt/73045166/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
