(+ Pete)

Could you please keep Pete on cc for RPi patches?


On Tue, 24 Mar 2020 at 23:02, Samer El-Haj-Mahmoud
<samer.el-haj-mahm...@arm.com> wrote:
>
> Tested with USB NICs (both ASIX AX88772C and Realtek gigabit ethernet). Both 
> work pretty well (tested IPv4 and IPv6).
>

Excellent, thanks.

Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org>

Pushed as 8b38aefc07bc..3daa70143953

Should we do the same for RPi3?


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard Biesheuvel 
> via Groups.Io
> Sent: Tuesday, March 24, 2020 5:55 PM
> To: Samer El-Haj-Mahmoud <sa...@elhajmahmoud.com>
> Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Leif Lindholm 
> <l...@nuviainc.com>
> Subject: Re: [edk2-devel] [[edk2-platform][PATCH 1/1] 
> Platform/RaspberryPi/RPi4: Enable HTTP Boot
>
> On Tue, 24 Mar 2020 at 22:53, Samer El-Haj-Mahmoud <sa...@elhajmahmoud.com> 
> wrote:
> >
> > Enable HTTP Boot (with and without TLS) on RPi4
> >
> > Cc: Leif Lindholm <l...@nuviainc.com>
> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>
> >
> > Signed-off-by: Samer El-Haj-Mahmoud <sa...@elhajmahmoud.com>
>
> Which NIC are you HTTP booting from?
>
> > ---
> >  Platform/RaspberryPi/RPi4/RPi4.dsc | 9 +++------
> >  1 file changed, 3 insertions(+), 6 deletions(-)
> >
> > diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc
> > b/Platform/RaspberryPi/RPi4/RPi4.dsc
> > index 2e98c3e16b91..f6b627af279c 100644
> > --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
> > +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
> > @@ -25,12 +25,6 @@ [Defines]
> >    SKUID_IDENTIFIER               = DEFAULT
> >    FLASH_DEFINITION               = 
> > Platform/RaspberryPi/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf
> >
> > -  #
> > -  # Network definition
> > -  #
> > -  DEFINE NETWORK_TLS_ENABLE       = FALSE
> > -  DEFINE NETWORK_HTTP_BOOT_ENABLE = FALSE
> > -
> >    #
> >    # Defines for default states.  These can be changed on the command line.
> >    # -D FLAG=VALUE
> > @@ -139,6 +133,7 @@ [LibraryClasses.common]
> >    IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
> >    BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
> >    OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > +  TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
> >
> >    #
> >    # Uncomment (and comment out the next line) For RealView Debugger.
> > The Standard IO window @@ -358,6 +353,8 @@ [PcdsFixedAtBuild.common]
> >
> > gEfiSecurityPkgTokenSpaceGuid.PcdRemovableMediaImageVerificationPolicy
> > |0x04
> >  !endif
> >
> > +  gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE
> > +
> >  [LibraryClasses.common]
> >    ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
> >    ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
> > --
> > 2.17.1
> >
>
> 
>
> IMPORTANT NOTICE: The contents of this email and any attachments are 
> confidential and may also be privileged. If you are not the intended 
> recipient, please notify the sender immediately and do not disclose the 
> contents to any other person, use it for any purpose, or store or copy the 
> information in any medium. Thank you.

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#56262): https://edk2.groups.io/g/devel/message/56262
Mute This Topic: https://groups.io/mt/72528422/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to