> -----Original Message----- > From: Ni, Ray > Sent: Wednesday, March 25, 2020 11:36 AM > To: Wu, Hao A; devel@edk2.groups.io > Cc: Dong, Eric; Laszlo Ersek; Kinney, Michael D; Zeng, Star; Brian J . Johnson > Subject: RE: [PATCH v3] UefiCpuPkg/MpInitLib DXE: Add PCD to control AP > status check interval > > > + TriggerTime = EFI_TIMER_PERIOD_MICROSECONDS ( > > + PcdGet32 (PcdCpuApStatusCheckIntervalInMicroSeconds) > > + ); > > Status = gBS->SetTimer ( > > mCheckAllApsEvent, > > TimerPeriodic, > > - AP_CHECK_INTERVAL > > + TriggerTime > > );
Hi Ray, My intention was to split the logic for easy reading. So you suggest to avoid adding a local variable, right? Best Regards, Hao Wu > > ASSERT_EFI_ERROR (Status); > > > I guess you introduced TriggerTime for debugging purpose. > But in the final patch, how about removing this local variable TriggerTime? > > Thanks, > Ray -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56248): https://edk2.groups.io/g/devel/message/56248 Mute This Topic: https://groups.io/mt/72534018/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
