Reviewed-by: Jiewen y...@intel.com > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ni, Ray > Sent: Wednesday, March 18, 2020 4:10 PM > To: Jiang, Guomin <guomin.ji...@intel.com>; devel@edk2.groups.io > Cc: Chaganty, Rangasai V <rangasai.v.chaga...@intel.com> > Subject: Re: [edk2-devel] [edk2-platform][PATCH] > IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR > > Reviewed-by: Ray Ni <ray...@intel.com> > > > -----Original Message----- > > From: Jiang, Guomin <guomin.ji...@intel.com> > > Sent: Wednesday, March 18, 2020 4:08 PM > > To: devel@edk2.groups.io > > Cc: Jiang, Guomin <guomin.ji...@intel.com>; Ni, Ray <ray...@intel.com>; > Chaganty, Rangasai V > > <rangasai.v.chaga...@intel.com> > > Subject: [edk2-platform][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: > Replace ASSERT_EFI_ERROR > > > > From: Guomin Jiang <guomin.ji...@intel.com> > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2589 > > > > According to code logic, it just judge the condition rather than the > > status, it should use the ASSERT rather than ASSERT_EFI_ERROR. > > > > Cc: Ray Ni <ray...@intel.com> > > Cc: Rangasai V Chaganty <rangasai.v.chaga...@intel.com> > > Signed-off-by: Guomin Jiang <guomin.ji...@intel.com> > > --- > > .../IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git > a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/I > ntelPciDeviceSecurityDxe.c > > > b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/I > ntelPciDeviceSecurityDxe.c > > index 29b6916f61..aa2bf14fa8 100644 > > --- > a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/I > ntelPciDeviceSecurityDxe.c > > +++ > b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/I > ntelPciDeviceSecurityDxe.c > > @@ -69,7 +69,7 @@ RecordPciDeviceInList( > > ASSERT_EFI_ERROR(Status); > > > > > > > > NewPciDevice = AllocateZeroPool(sizeof(*NewPciDevice)); > > > > - ASSERT_EFI_ERROR(NewPciDevice != NULL); > > > > + ASSERT(NewPciDevice != NULL); > > > > > > > > NewPciDevice->Signature = PCI_DEVICE_INSTANCE_SIGNATURE; > > > > NewPciDevice->PciSegment = PciSegment; > > > > -- > > 2.25.1.windows.1 > > >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#55955): https://edk2.groups.io/g/devel/message/55955 Mute This Topic: https://groups.io/mt/72044540/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
