Reviewed-by: Ashley DeSimone <ashley.e.desim...@intel.com> -----Original Message----- From: Desimone, Nathaniel L <nathaniel.l.desim...@intel.com> Sent: Monday, March 16, 2020 10:33 AM To: devel@edk2.groups.io Cc: Desimone, Ashley E <ashley.e.desim...@intel.com>; Pandya, Puja <puja.pan...@intel.com>; Bjorge, Erik C <erik.c.bjo...@intel.com>; Bret Barkelew <bret.barke...@microsoft.com> Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Use /S switch to pass command args in installer
Cc: Ashley DeSimone <ashley.e.desim...@intel.com> Cc: Puja Pandya <puja.pan...@intel.com> Cc: Erik Bjorge <erik.c.bjo...@intel.com> Cc: Bret Barkelew <bret.barke...@microsoft.com> Signed-off-by: Nate DeSimone <nathaniel.l.desim...@intel.com> --- edkrepo_installer/EdkRepoInstaller/App.xaml.cs | 4 ++-- edkrepo_installer/EdkRepoInstaller/InstallWorker.cs | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/edkrepo_installer/EdkRepoInstaller/App.xaml.cs b/edkrepo_installer/EdkRepoInstaller/App.xaml.cs index 58186c9..5d23624 100644 --- a/edkrepo_installer/EdkRepoInstaller/App.xaml.cs +++ b/edkrepo_installer/EdkRepoInstaller/App.xaml.cs @@ -185,7 +185,7 @@ namespace TianoCore.EdkRepoInstaller { InstallLogger.Log(string.Format("{0} is a third party version of {1}. {0} is already installed.", DisplayName, ProductName)); InstallLogger.Log(string.Format("To install this version of {1}, {0} must be uninstalled first.", DisplayName, ProductName)); - SilentProcess p = SilentProcess.StartConsoleProcessSilently("cmd.exe", string.Format("/c \"{0}\"", UninstallString)); + SilentProcess p = SilentProcess.StartConsoleProcessSilently("cmd.exe", string.Format("/S /C \"{0}\"", UninstallString)); p.WaitForExit(); Thread.Sleep(4000); } @@ -200,7 +200,7 @@ namespace TianoCore.EdkRepoInstaller ); if (Uninstall == MessageBoxResult.Yes) { - SilentProcess p = SilentProcess.StartConsoleProcessSilently("cmd.exe", string.Format("/c \"{0}\"", UninstallString)); + SilentProcess p = SilentProcess.StartConsoleProcessSilently("cmd.exe", string.Format("/S /C \"{0}\"", UninstallString)); p.WaitForExit(); Thread.Sleep(1000); } diff --git a/edkrepo_installer/EdkRepoInstaller/InstallWorker.cs b/edkrepo_installer/EdkRepoInstaller/InstallWorker.cs index 5a358f9..c37189b 100644 --- a/edkrepo_installer/EdkRepoInstaller/InstallWorker.cs +++ b/edkrepo_installer/EdkRepoInstaller/InstallWorker.cs @@ -672,7 +672,7 @@ namespace TianoCore.EdkRepoInstaller { InstallLogger.Log(string.Format("Uninstalling {0}...", UninstallerPath)); string UninstallString = string.Format("\"{0}\" /Uninstall /Passive", UninstallerPath); - SilentProcess p = SilentProcess.StartConsoleProcessSilently("cmd.exe", string.Format("/c \"{0}\"", UninstallString)); + SilentProcess p = SilentProcess.StartConsoleProcessSilently("cmd.exe", string.Format("/S /C \"{0}\"", UninstallString)); p.WaitForExit(); Thread.Sleep(4000); } -- 2.24.0.windows.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#55935): https://edk2.groups.io/g/devel/message/55935 Mute This Topic: https://groups.io/mt/72004234/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-