On Wed, 4 Mar 2020 at 15:51, Laszlo Ersek <ler...@redhat.com> wrote: > > On 03/04/20 10:54, Ard Biesheuvel wrote: > > On Wed, 4 Mar 2020 at 10:44, Laszlo Ersek <ler...@redhat.com> wrote: > >> > >> Repo: https://pagure.io/lersek/edk2.git > >> Branch: timeout_var > >> > >> In the PlatformBootManagerLib instances, set the Timeout global variable > >> to the same value as PcdPlatformBootTimeOut. This way the "setvar" > >> command in the UEFI shell, and the "efibootmgr" command in a Linux > >> guest, can report the front page timeout that was requested on the QEMU > >> command line (see GetFrontPageTimeoutFromQemu() in > >> "OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c"). > >> > >> A DEBUG_VERBOSE message is logged on success too, for our QE team's > >> sake. > >> > >> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > >> Cc: Jordan Justen <jordan.l.jus...@intel.com> > >> Cc: Leif Lindholm <l...@nuviainc.com> > >> Cc: Philippe Mathieu-Daudé <phi...@redhat.com> > >> > >> Thanks > >> Laszlo > >> > >> Laszlo Ersek (2): > >> OvmfPkg/PlatformBootManagerLib: sync Timeout with > >> PcdPlatformBootTimeOut > >> ArmVirtPkg/PlatformBootManagerLib: sync Timeout with > >> PcdPlatformBootTimeOut > >> > > > > Provided that the use of the bare 'sizeof <identifier>' doesn't throw > > up any build errors with Clang (I seem to remember a report from Mike > > Kinney about this?) > > > > Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > > I use the "sizeof" operator exclusively without parens if the operand is > not a type name, at least in packages that I co-maintain. I don't recall > any particular build failures (even from the edk2 CI). >
OK fine. I don't remember the exact details, and I kind of like this notation as well, so ... :-) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#55418): https://edk2.groups.io/g/devel/message/55418 Mute This Topic: https://groups.io/mt/71722702/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
