On 02/28/20 10:50, Laszlo Ersek wrote:
> In particular, in patch "OvmfPkg/MptScsiDxe: Install stubbed
> EXT_SCSI_PASS_THRU", the pattern should be laid out like this:
>
> -----------
> Status = gBS->InstallProtocolInterface (...);
> if (EFI_ERROR (Status)) {
> goto FreeDev;
> }
> return EFI_SUCCESS;
>
> FreeDev:
> FreePool (Dev);
>
> return Status;
> -----------
>
> and then the rest of the patches should build upon that -- introduce new
> labels always at the top of the existent "stack" of labels.
If it's OK with you, I'd like to stop reviewing version 2 at this point.
I'm going to be tripped up continuously by the mixing of goto +
conditional release.
I'll make an effort to review v3 reasonably quickly once you post it.
Thanks,
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#55062): https://edk2.groups.io/g/devel/message/55062
Mute This Topic: https://groups.io/mt/71570013/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
