On 02/26/20 22:40, Ard Biesheuvel wrote: > On Wed, 26 Feb 2020 at 21:32, Brian J. Johnson <brian.john...@hpe.com> wrote: >>
>> I'm not an official reviewer, but I'd feel better about this patch if >> you added a condition to exit the "while (PeCompat->Type != 0)" loop if >> PeCompat ever gets pointed outside of the section. Otherwise a >> malformed or corrupted .compat section could send you off dereferencing >> anything at all. >> > > Good point, I'll look into that. You can keep my Acked-by if this is going to be the only change for this patch, in v4. Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#54998): https://edk2.groups.io/g/devel/message/54998 Mute This Topic: https://groups.io/mt/71572297/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
