On 02/18/20 21:42, Kinney, Michael D wrote: > Hi Laszlo, > > I agree with your assessments. > > One comment below. > > Mike > >> -----Original Message----- >> From: Laszlo Ersek <ler...@redhat.com> >> Sent: Tuesday, February 18, 2020 12:04 PM >> To: Gao, Liming <liming....@intel.com>; Guptha, Soumya K >> <soumya.k.gup...@intel.com>; Kinney, Michael D >> <michael.d.kin...@intel.com>; l...@nuviainc.com; af...@apple.com >> Cc: devel@edk2.groups.io >> Subject: Re: Patch List for 202002 stable tag
>>> https://edk2.groups.io/g/devel/message/54510 [PATCH v6 0/2] >>> Enhancement and Fixes to BaseHashApiLib >> >> Hm. I feel like I need some convincing that patch#1 -- >> "CryptoPkg/BaseHashApiLib: Align BaseHashApiLib with TPM 2.0 >> Implementation" -- is *also* a bugfix (like patch#2). >> >> That question matters because the reviews: >> >> - https://edk2.groups.io/g/devel/message/54513 >> - https://edk2.groups.io/g/devel/message/54567 >> >> were not posted before the SFF. >> >> ... I guess it's OK. > > The description of the bug does not emphasis that this really is a bug > fix. There were additional review comments from the CryptoPkg > reviewers after the initial review/commit of this feature. These > changes address that feedback. The alignment with TPM 2.0 is to use > an existing set of defines for the hash algorithms instead of define > yet another set of defines. Details in this thread: > > https://edk2.groups.io/g/devel/topic/70960524#53733 Thanks! Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#54620): https://edk2.groups.io/g/devel/message/54620 Mute This Topic: https://groups.io/mt/71371549/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
