Reviewed-by: Liming Gao <liming....@intel.com> > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of GuoMinJ > Sent: Thursday, February 13, 2020 4:34 PM > To: devel@edk2.groups.io > Cc: GuoMinJ <newexplor...@gmail.com> > Subject: [edk2-devel] [PATCH 1/3] FmpDevicePkg/FmpDxe: Issues reported by ECC > in EDK2. > > https://bugzilla.tianocore.org/show_bug.cgi?id=2515 > > Change the FmpDevicePkg to match the ECC check rule > > Signed-off-by: GuoMinJ <newexplor...@gmail.com> > --- > FmpDevicePkg/FmpDxe/Dependency.c | 4 ++-- > FmpDevicePkg/FmpDxe/Dependency.h | 2 +- > FmpDevicePkg/FmpDxe/FmpDxe.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/FmpDevicePkg/FmpDxe/Dependency.c > b/FmpDevicePkg/FmpDxe/Dependency.c > index b63a36b989..8f97c42916 100644 > --- a/FmpDevicePkg/FmpDxe/Dependency.c > +++ b/FmpDevicePkg/FmpDxe/Dependency.c > @@ -163,8 +163,8 @@ Push ( > /** > Pop an element from the stack. > > - @param[in] Value Element to pop. > - @param[in] Type Type of element. > + @param[out] Element Element to pop. > + @param[in] Type Type of element. > > @retval EFI_SUCCESS The value was popped onto the stack. > @retval EFI_ACCESS_DENIED The pop operation underflowed the stack. > diff --git a/FmpDevicePkg/FmpDxe/Dependency.h > b/FmpDevicePkg/FmpDxe/Dependency.h > index a2aaaceeae..badd2542d6 100644 > --- a/FmpDevicePkg/FmpDxe/Dependency.h > +++ b/FmpDevicePkg/FmpDxe/Dependency.h > @@ -56,7 +56,7 @@ EvaluateImageDependencies ( > IN CONST EFI_GUID ImageTypeId, > IN CONST UINT32 Version, > IN CONST EFI_FIRMWARE_IMAGE_DEP *Dependencies, > - IN CONST UINT32 DependenciesSize, > + IN CONST UINT32 DepexSize, > OUT BOOLEAN *IsSatisfied > ); > > diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c b/FmpDevicePkg/FmpDxe/FmpDxe.c > index aa92331966..5b523291e4 100644 > --- a/FmpDevicePkg/FmpDxe/FmpDxe.c > +++ b/FmpDevicePkg/FmpDxe/FmpDxe.c > @@ -413,7 +413,7 @@ PopulateDescriptor ( > } > if (!EFI_ERROR (Status) && Image != NULL) { > IsDepexValid = ValidateImageDepex ((EFI_FIRMWARE_IMAGE_DEP *) Image, > ImageSize, &DepexSize); > - if (IsDepexValid == TRUE) { > + if (IsDepexValid) { > Private->Descriptor.Dependencies = AllocatePool (DepexSize); > if (Private->Descriptor.Dependencies != NULL) { > CopyMem (Private->Descriptor.Dependencies->Dependencies, Image, > DepexSize); > -- > 2.17.1 > > >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#54344): https://edk2.groups.io/g/devel/message/54344 Mute This Topic: https://groups.io/mt/71236335/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
