Hi Lin,

Next time you might need have Mike Kinney in the cc list:)

Reviewed-by: Zailiang Sun <zailiang....@intel.com>

-----Original Message-----
From: Gary Lin <g...@suse.com> 
Sent: Wednesday, February 12, 2020 2:24 PM
To: devel@edk2.groups.io
Cc: Sun, Zailiang <zailiang....@intel.com>; Qian, Yi <yi.q...@intel.com>
Subject: [PATCH 1/2] Vlv2TbltDevicePkg/GenerateCapsule: Create cab files with 
signed capsules

The cab file previously contained the unsigned payload without the FMP
header, so the firmware would reject the capsule generated by fwupd
based on the cab file. This commit copies the signed capsule into the
cab file so that fwupd can generate a valid capsule.

Cc: Zailiang Sun <zailiang....@intel.com>
cc: Yi Qian <yi.q...@intel.com>
Signed-off-by: Gary Lin <g...@suse.com>
---
 .../Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleAll.py  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleAll.py
 
b/Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleAll.py
index a37648ac96..1a6c597c4a 100644
--- 
a/Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleAll.py
+++ 
b/Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleAll.py
@@ -181,7 +181,7 @@ def GenCapsuleDevice (BaseName, PayloadFileName, Guid, 
Version, Lsv, CapsulesPat
         LogAlways (ProcessOutput[0].decode())
         Error ('GenerateCapsule returned an error')
 
-    Copy (PayloadFileName, (CapsulesPath, 'firmware.bin'))
+    Copy (FmpCapsuleFile, (CapsulesPath, 'firmware.bin'))
     MetaInfoXml = MetaInfoXmlTemplate
     MetaInfoXml = MetaInfoXml.replace ('FMP_CAPSULE_GUID', Guid)
     MetaInfoXml = MetaInfoXml.replace ('FMP_CAPSULE_BASE_NAME', BaseName)
-- 
2.16.4


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54260): https://edk2.groups.io/g/devel/message/54260
Mute This Topic: https://groups.io/mt/71205996/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to