This patch set is good to me.
Reviewed-by: Bob Feng <bob.c.f...@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of PierreGondois
Sent: Monday, February 10, 2020 6:49 PM
To: devel@edk2.groups.io
Cc: Pierre Gondois <pierre.gond...@arm.com>; Feng, Bob C
<bob.c.f...@intel.com>; Gao, Liming <liming....@intel.com>;
sami.muja...@arm.com; pierre.gond...@arm.com; n...@arm.com
Subject: [edk2-devel] [PATCH v4 0/2] BaseTools: Rationalise makefile generation
v4:
Remove caret in NASM_INC macro:
I could not reproduce the build fail Bob Feng had when issuing
the following command:
build -p UefiCpuPkg\UefiCpuPkg.dsc -a IA32 -t VS2015x86
Nonetheless, this v4 should only have an impact on the builds
made on Windows platforms using nmake.
The changes can be seen at
https://github.com/PierreARM/edk2/tree/720_BaseTools_Rationalise_makefile_generation_v4
Pierre Gondois (2):
BaseTools: Rationalise makefile generation
BaseTools: Remove caret in NASM_INC macro
BaseTools/Source/Python/AutoGen/GenMake.py | 145 +++++++++++---------
BaseTools/Source/Python/AutoGen/IncludesAutoGen.py | 34 +++--
BaseTools/Source/Python/AutoGen/PlatformAutoGen.py | 13 +-
BaseTools/Source/Python/build/build.py | 25 ++--
4 files changed, 120 insertions(+), 97 deletions(-)
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#54249): https://edk2.groups.io/g/devel/message/54249
Mute This Topic: https://groups.io/mt/71134119/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
