On Fri, Feb 07, 2020 at 18:13:19 +0530, Pankaj Bansal wrote: > Keep the names and location of files as mentioned in ArmPlatformPkg.
This isn't really a goal in itself, but the AArch64/ addition is good cleanup, so I'm not objecting. But please mention that one explicitly. > This helps in porting the common changes (if any in future) easily. > > Signed-off-by: Pankaj Bansal <pankaj.ban...@nxp.com> > --- > Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 2 +- > .../AArch64}/NxpQoriqLsHelper.S | 2 +- > .../Library/{PlatformLib => ArmPlatformLib}/ArmPlatformLib.c | 2 +- > .../{PlatformLib => ArmPlatformLib}/ArmPlatformLib.inf | 4 ++-- > .../NxpQoriqLsMem.c => ArmPlatformLib/ArmPlatformLibMem.c} | 0 > 5 files changed, 5 insertions(+), 5 deletions(-) > rename Platform/NXP/LS1043aRdbPkg/Library/{PlatformLib => > ArmPlatformLib/AArch64}/NxpQoriqLsHelper.S (88%) > rename Platform/NXP/LS1043aRdbPkg/Library/{PlatformLib => > ArmPlatformLib}/ArmPlatformLib.c (93%) > rename Platform/NXP/LS1043aRdbPkg/Library/{PlatformLib => > ArmPlatformLib}/ArmPlatformLib.inf (89%) > rename Platform/NXP/LS1043aRdbPkg/Library/{PlatformLib/NxpQoriqLsMem.c => > ArmPlatformLib/ArmPlatformLibMem.c} (100%) > > diff --git a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > index 7cffd09d7d..bc6fa4f19d 100644 > --- a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > +++ b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > @@ -26,7 +26,7 @@ > !include Silicon/NXP/LS1043A/LS1043A.dsc.inc > > [LibraryClasses.common] > - > ArmPlatformLib|Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf > + > ArmPlatformLib|Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf > RealTimeClockLib|Silicon/Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.inf > > [PcdsFixedAtBuild.common] > diff --git > a/Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/NxpQoriqLsHelper.S > b/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/AArch64/NxpQoriqLsHelper.S > similarity index 88% > rename from Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/NxpQoriqLsHelper.S > rename to > Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/AArch64/NxpQoriqLsHelper.S > index 84ee8c9f97..dfbf73675a 100644 > --- a/Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/NxpQoriqLsHelper.S > +++ > b/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/AArch64/NxpQoriqLsHelper.S > @@ -1,7 +1,7 @@ > # @file > # > # Copyright (c) 2012-2013, ARM Limited. All rights reserved. > -# Copyright 2017 NXP > +# Copyright 2017, 2020 NXP I don't think renaming a file qualifies for updating copyright on it. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > diff --git a/Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.c > b/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c > similarity index 93% > rename from Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.c > rename to Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c > index eac7d4aa4e..718c71bf02 100644 > --- a/Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.c > +++ b/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c > @@ -6,7 +6,7 @@ > * > * Copyright (c) 2011-2012, ARM Limited. All rights reserved. > * Copyright (c) 2016, Freescale Semiconductor, Inc. All rights reserved. > -* Copyright 2017 NXP > +* Copyright 2017, 2020 NXP Same again. / Leif > * SPDX-License-Identifier: BSD-2-Clause-Patent > * > **/ > diff --git > a/Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf > b/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf > similarity index 89% > rename from Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf > rename to Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf > index 054dc4d003..6396d2982b 100644 > --- a/Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf > +++ b/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf > @@ -27,8 +27,8 @@ > SocLib > > [Sources.common] > - NxpQoriqLsHelper.S | GCC > - NxpQoriqLsMem.c > + AArch64/NxpQoriqLsHelper.S | GCC > + ArmPlatformLibMem.c > ArmPlatformLib.c > > [Ppis] > diff --git a/Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c > b/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLibMem.c > similarity index 100% > rename from Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c > rename to > Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLibMem.c > -- > 2.17.1 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#54198): https://edk2.groups.io/g/devel/message/54198 Mute This Topic: https://groups.io/mt/71046332/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-