Ray, I have responded to your review comments. These patches has been changed accommodating your previous review comments. Please check.
Thanks Ashraf > -----Original Message----- > From: Ni, Ray <ray...@intel.com> > Sent: Monday, February 10, 2020 1:10 PM > To: Javeed, Ashraf <ashraf.jav...@intel.com>; devel@edk2.groups.io > Cc: Wang, Jian J <jian.j.w...@intel.com>; Wu, Hao A <hao.a...@intel.com> > Subject: RE: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 00/12] PciBusDxe: > New PCI Express features > > Ashraf, > I reviewed the first and second patches. > > Can you please check my review comments to your December's patches and > make sure either your new code changes followed the comments, or we > continue discuss the review comments if you don't agree? > > I just found some code changes didn't follow as comments suggested. > > Thanks, > Ray > > > > -----Original Message----- > > From: Javeed, Ashraf <ashraf.jav...@intel.com> > > Sent: Saturday, February 8, 2020 4:05 AM > > To: devel@edk2.groups.io > > Cc: Wang, Jian J <jian.j.w...@intel.com>; Wu, Hao A > > <hao.a...@intel.com>; Ni, Ray <ray...@intel.com> > > Subject: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 00/12] PciBusDxe: New > > PCI Express features > > > > The PciBusDxe is enhanced to initialize 10 PCI Express features (patch > > index 3 to 12). > > All these PCI Express features attributes are defined based on the new > > PCI Express Platform Protocol definition (as per its ECR draft version > > 0.8): https://bugzilla.tianocore.org/show_bug.cgi?id=1954. > > For MPS, MRRS:- > > https://bugzilla.tianocore.org/show_bug.cgi?id=2194 > > For RO, NS, CTO:- > > https://bugzilla.tianocore.org/show_bug.cgi?id=2313 > > For AtomicOp, Extended Tag, LTR:- > > https://bugzilla.tianocore.org/show_bug.cgi?id=2499 > > For ASPM, CCC:- > > https://bugzilla.tianocore.org/show_bug.cgi?id=2500 > > > > Signed-off-by: Ashraf Javeed <ashraf.jav...@intel.com> > > Cc: Jian J Wang <jian.j.w...@intel.com> > > Cc: Hao A Wu <hao.a...@intel.com> > > Cc: Ray Ni <ray...@intel.com> > > > > > > Ashraf Javeed (12): > > MdeModulePkg/PciBusDxe: Setup for PCI Express features > > MdeModulePkg/PciBusDxe: Setup PCI Express init phase > > PciBusDxe: New PCI Express feature Max_Payload_Size > > PciBusDxe: New PCI Express feature Max_Read_Req_Size > > PciBusDxe: New PCI Express feature Relax Ordering > > PciBusDxe: New PCI Express feature No-Snoop > > PciBusDxe: New PCI Express feature Completion Timeout > > PciBusDxe: New PCI Express feature AtomicOp > > PciBusDxe: New PCI Express feature LTR > > PciBusDxe: New PCI Express feature Extended Tag > > PciBusDxe: New PCI Express feature ASPM support > > PciBusDxe: New PCI Express feature Common CLock Config > > > > MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c | 6 ++- > > MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.h | 25 ++++++++++- > > MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf | 11 ++++- > > MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.c | 181 > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-- > --- > > ----------- > > MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 12 +++++- > > MdeModulePkg/Bus/Pci/PciBusDxe/PciExpressFeatures.c | 2178 > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > +++++++++++++++++++++++++++ > > MdeModulePkg/Bus/Pci/PciBusDxe/PciExpressFeatures.h | 399 > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > ++++++++++++++++++++++++++++++++++++++++++ > > MdeModulePkg/Bus/Pci/PciBusDxe/PciFeatureSupport.c | 1019 > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > ++++++++++++++++++++++++++++++++++++++++++++++++ > > MdeModulePkg/Bus/Pci/PciBusDxe/PciFeatureSupport.h | 304 > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > + > > MdeModulePkg/Bus/Pci/PciBusDxe/PciPlatformSupport.c | 902 > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > MdeModulePkg/Bus/Pci/PciBusDxe/PciPlatformSupport.h | 119 > > ++++++++++++++++++++++++++++++++++++++++++++++++++++ > > 11 files changed, 5116 insertions(+), 40 deletions(-) create mode > > 100644 MdeModulePkg/Bus/Pci/PciBusDxe/PciExpressFeatures.c > > create mode 100644 > > MdeModulePkg/Bus/Pci/PciBusDxe/PciExpressFeatures.h > > create mode 100644 MdeModulePkg/Bus/Pci/PciBusDxe/PciFeatureSupport.c > > create mode 100644 MdeModulePkg/Bus/Pci/PciBusDxe/PciFeatureSupport.h > > create mode 100644 > > MdeModulePkg/Bus/Pci/PciBusDxe/PciPlatformSupport.c > > create mode 100644 > > MdeModulePkg/Bus/Pci/PciBusDxe/PciPlatformSupport.h > > > > -- > > 2.21.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#54118): https://edk2.groups.io/g/devel/message/54118 Mute This Topic: https://groups.io/mt/71063052/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
