On 02/06/20 06:23, Hao A Wu wrote: > The series will resolve a backward compatibility issue with pre-built > binaries (e.g. FSP) introduced by commit 88bd0661661. > > The relocation of 'MicrocodePatchRegionSize' and 'MicrocodePatchAddress' > fields in structure CPU_MP_DATA may cause access issue for platforms that > use pre-built FSP binary, since the offset of these microcode related > fields in CPU_MP_DATA can be different between PEI phase (in the pre-built > binary) and DXE phase (in current code implementation). > > The series will use the newly introduced EDKII microcode patch HOB instead > for the DXE phase to get the information of the loaded (done in PEI phase) > microcode patches data. > > Cc: Michael Kubacki <michael.a.kuba...@intel.com> > Cc: Michael D Kinney <michael.d.kin...@intel.com> > Cc: Eric Dong <eric.d...@intel.com> > Cc: Ray Ni <ray...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > > Hao A Wu (2): > Revert UefiCpuPkg/MpInitLib: Relocate microcode patch fields in > CPU_MP_DATA > UefiCpuPkg/MpInitLib: Not pass microcode info between archs in > CPU_MP_DATA > > UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 3 +- > UefiCpuPkg/Library/MpInitLib/MpLib.h | 27 +++++++++++- > UefiCpuPkg/Library/MpInitLib/Microcode.c | 43 ++++++++++++++++++++ > UefiCpuPkg/Library/MpInitLib/MpLib.c | 20 +++++---- > UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 3 +- > 5 files changed, 82 insertions(+), 14 deletions(-) >
Looks plausible to me, but my review doesn't (and shouldn't) carry much weight here. Acked-by: Laszlo Ersek <ler...@redhat.com> Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53865): https://edk2.groups.io/g/devel/message/53865 Mute This Topic: https://groups.io/mt/71015994/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
