Vitaly: This change will cause CryptoPkg openssl build failure, because OpensslLib.inf undefines _MSC_VER macro to make sure openssl source code be built in edk2 project without using MS VS functions.
Now, I have no good solution to fix this issue. One way is to use defined(_MSC_EXTENSIONS) && !defined(__clang__), another way is to investigate whether we can remove -fms-compatibility option in CLANGPDB. Thanks Liming > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Vitaly > Cheptsov via Groups.Io > Sent: Saturday, February 1, 2020 5:17 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH 0/1] Use _MSC_VER to determine MSVC compiler > > Patch details are explained in > https://bugzilla.tianocore.org/show_bug.cgi?id=2397. > We request this to be merged in edk2-stable202002. > > Vitaly Cheptsov (1): > MdePkg: Use _MSC_VER to determine MSVC compiler > > MdePkg/Include/AArch64/ProcessorBind.h | 2 +- > MdePkg/Include/Arm/ProcessorBind.h | 8 ++++---- > MdePkg/Include/Base.h | 10 +++++----- > MdePkg/Include/Ia32/ProcessorBind.h | 6 +++--- > MdePkg/Include/X64/ProcessorBind.h | 6 +++--- > 5 files changed, 16 insertions(+), 16 deletions(-) > > -- > 2.21.1 (Apple Git-122.3) > > > -=-=-=-=-=-= > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#53623): https://edk2.groups.io/g/devel/message/53623 > Mute This Topic: https://groups.io/mt/70882954/1759384 > Group Owner: devel+ow...@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [liming....@intel.com] > -=-=-=-=-=-= -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53645): https://edk2.groups.io/g/devel/message/53645 Mute This Topic: https://groups.io/mt/70882954/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
