Reviewed-by: Zhichao Gao <zhichao....@intel.com> > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Ashish Singhal > Sent: Monday, January 20, 2020 1:45 PM > To: devel@edk2.groups.io; Ni, Ray <ray...@intel.com>; Gao, Zhichao > <zhichao....@intel.com> > Cc: Ashish Singhal <ashishsin...@nvidia.com> > Subject: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fix > FADT Parser > > FADT parser was checking for reduced ACPI flag incorrectly leading to > incorrect error message if FIRMWARE_CTRL and X_FIRMWARE_CTRL are > both 0. > > Signed-off-by: Ashish Singhal <ashishsin...@nvidia.com> > --- > .../UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser. > c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser. > c > index 5b8cc174f1..8acfbac3b1 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser. > c > +++ > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtPars > +++ er.c > @@ -253,7 +253,7 @@ ParseAcpiFadt ( > // present. > if ((Trace) && > (Flags != NULL) && > - ((*Flags & EFI_ACPI_6_3_HW_REDUCED_ACPI) != 0)) { > + ((*Flags & EFI_ACPI_6_3_HW_REDUCED_ACPI) != > + EFI_ACPI_6_3_HW_REDUCED_ACPI)) { > IncrementErrorCount (); > Print (L"ERROR: No FACS table found, " > L"both X_FIRMWARE_CTRL and FIRMWARE_CTRL are zero.\n"); > -- > 2.17.1 > > >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53392): https://edk2.groups.io/g/devel/message/53392 Mute This Topic: https://groups.io/mt/69926879/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
