Wei: Thanks for your update. I think those unit tests are enough. Liming > -----Original Message----- > From: Xu, Wei6 <wei6...@intel.com> > Sent: Thursday, January 16, 2020 9:31 PM > To: Gao, Liming <liming....@intel.com>; devel@edk2.groups.io > Subject: RE: [edk2-devel][PATCH 0/3] Fmp Capsule Dependency implementation. > > Hi Liming, > > Thanks a lot for review. > > We did following test: > On OVMF: > 1. Unit test to verify the handling of all op-codes. > 2. Unit test for updated APIs > 3. Verify capsule update process with satisfied/unsatisfied/invalid > dependency. > > On real dev machine: > 1. Update Fmp Device which supports dependency, with capsule which has > dependency inside. > 2. Update Fmp Device which supports dependency, with capsule which has no > dependency inside. > 3. Update Fmp Device which doesn't support dependency, with capsule which has > dependency inside. > 4. Update Fmp Device which doesn't support dependency, with capsule which has > no dependency inside. > > BR, > Wei > > > -----Original Message----- > > From: Gao, Liming <liming....@intel.com> > > Sent: Thursday, January 16, 2020 8:25 PM > > To: devel@edk2.groups.io; Xu, Wei6 <wei6...@intel.com> > > Subject: RE: [edk2-devel][PATCH 0/3] Fmp Capsule Dependency implementation. > > > > Wei: > > The code change looks good. Reviewed-by: Liming Gao <liming....@intel.com> > > > > Please share which test have been done. > > > > Thanks > > Liming > > > -----Original Message----- > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Xu, > > > Wei6 > > > Sent: Friday, January 10, 2020 1:35 PM > > > To: devel@edk2.groups.io > > > Subject: [edk2-devel][PATCH 0/3] Fmp Capsule Dependency implementation. > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2421 > > > > > > This series implements Fmp Capsule Dependency. > > > Fmp Capsule Dependency is an incremental change of Fmp Capsule Update. > > > The capsule format is extended to include a set of binary encoded > > > dependency > > expression. > > > The dependency expression is evaluated before update is applied. > > > This feature is defined in UEFI Spec 2.8. > > > > > > Wei6 Xu (3): > > > MdePkg: Add definition for Fmp Capsule Dependency. > > > MdeModulePkg/CapsuleApp: Enhance CapsuleApp for Fmp Capsule > > Dependency > > > FmdDevicePkg/FmpDxe: Support Fmp Capsule Dependency. > > > > > > FmpDevicePkg/FmpDxe/Dependency.c | 679 > > ++++++++++++++++++++++ > > > FmpDevicePkg/FmpDxe/Dependency.h | 63 ++ > > > FmpDevicePkg/FmpDxe/FmpDxe.c | 238 +++++++- > > > FmpDevicePkg/FmpDxe/FmpDxe.inf | 4 +- > > > FmpDevicePkg/FmpDxe/FmpDxeLib.inf | 4 +- > > > MdeModulePkg/Application/CapsuleApp/CapsuleDump.c | 16 +- > > > MdePkg/Include/Guid/SystemResourceTable.h | 19 +- > > > MdePkg/Include/Protocol/FirmwareManagement.h | 35 +- > > > 8 files changed, 1030 insertions(+), 28 deletions(-) create mode > > > 100644 FmpDevicePkg/FmpDxe/Dependency.c create mode 100644 > > > FmpDevicePkg/FmpDxe/Dependency.h > > > > > > -- > > > 2.16.2.windows.1 > > > > > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53310): https://edk2.groups.io/g/devel/message/53310 Mute This Topic: https://groups.io/mt/69595647/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
