The first patch refactors the SdMmcClockSupply function with a goal of sending the EdkiiSdMmcSwitchClockFreq notification before we send the CMD13 to check the switch status in eMMC init flow. This is required to avoid sending the CMD13 on link that still has not been fixed by platform.
To avoid changing the driver behavior we avoid sending notifications when the clock is setup for the first time or when we setup the clock after the voltage switch procedure(adressed in second patch). The second patch in the series optimizes the SD card detection routine to stop it from going through the process of internal clock setup after switching the voltage. According to SD HC specification there is no need to setup internal clock all over again. Tests performed: - Booted eMMC in HS400 mode on platform which required post clock freq fixes I wasn't able to test SD card yet due to the lack of setup with working SD. The patch series is available on github here: https://github.com/malbecki/edk2/tree/sdmmc_post_freq_notify Cc: Hao A Wu <hao.a...@intel.com> Cc: Marcin Wojtas <m...@semihalf.com> Cc: Zhichao Gao <zhichao....@intel.com> Cc: Liming Gao <liming....@intel.com> Mateusz Albecki (2): SdMmcPciHcDxe: Send EdkiiSdMmcSwitchClockFreq after SD clock start MdeModulePkg/SdMmcPciHcDxe: Add function to start SD clock MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c | 20 +-- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 25 +--- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 24 ++++ MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 136 +++++++++++---------- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h | 45 ++----- 5 files changed, 112 insertions(+), 138 deletions(-) -- 2.14.1.windows.1 -------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52462): https://edk2.groups.io/g/devel/message/52462 Mute This Topic: https://groups.io/mt/68852773/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
