On 12/12/19 12:53 AM, Ni, Ray wrote: > Tom, > Why all DR registers are not pushed to stack in VC handler? > I thought only DR7 pushing is skipped.
It was probably just to be on the safe side in case the hypervisor didn't remove the intercept for them. And since none of the other debug registers are used by the #VC handler and their values aren't restored on exit, I just decided not to push them. But I can push them if you think it best. Thanks, Tom > > Thanks, > Ray > >> -----Original Message----- >> From: Tom Lendacky <thomas.lenda...@amd.com> >> Sent: Thursday, November 21, 2019 4:07 AM >> To: devel@edk2.groups.io >> Cc: Justen, Jordan L <jordan.l.jus...@intel.com>; Laszlo Ersek >> <ler...@redhat.com>; Ard Biesheuvel >> <ard.biesheu...@linaro.org>; Kinney, Michael D <michael.d.kin...@intel.com>; >> Gao, Liming <liming....@intel.com>; Dong, >> Eric <eric.d...@intel.com>; Ni, Ray <ray...@intel.com>; Brijesh Singh >> <brijesh.si...@amd.com> >> Subject: [RFC PATCH v3 22/43] UefiCpuPkg/CpuExceptionHandler: Add support >> for DR7 Read/Write NAE events >> >> BZ: >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2198&data=02%7C01%7Cthomas.lendacky%40amd.com%7C6858e5b903674581483b08d77ed0123b%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637117304434355086&sdata=jRdTglBwajIycWATDilfbyC%2BrvPOTFCUl0MqhhuE5nA%3D&reserved=0 >> >> Under SEV-ES, a DR7 read or write intercept generates a #VC exception. >> The #VC handler must provide special support to the guest for this. On >> a DR7 write, the #VC handler must cache the value and issue a VMGEXIT >> to notify the hypervisor of the write. However, the #VC handler must >> not actually set the value of the DR7 register. On a DR7 read, the #VC >> handler must return the cached value of the DR7 register to the guest. >> VMGEXIT is not invoked for a DR7 register read. >> >> To avoid exception recursion, a #VC exception will not try to read and >> push the actual debug registers into the EFI_SYSTEM_CONTEXT_X64 struct >> and instead push zeroes. The #VC exception handler does not make use of >> the debug registers from saved context. >> >> Cc: Eric Dong <eric.d...@intel.com> >> Cc: Ray Ni <ray...@intel.com> >> Cc: Laszlo Ersek <ler...@redhat.com> >> Signed-off-by: Tom Lendacky <thomas.lenda...@amd.com> >> --- >> .../X64/AMDSevVcCommon.c | 68 +++++++++++++++++++ >> .../X64/ExceptionHandlerAsm.nasm | 15 ++++ >> 2 files changed, 83 insertions(+) >> >> diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/AMDSevVcCommon.c >> b/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/AMDSevVcCommon.c >> index 1d7c34e7e442..22393f72d795 100644 >> --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/AMDSevVcCommon.c >> +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/AMDSevVcCommon.c >> @@ -13,6 +13,12 @@ >> >> #define CR4_OSXSAVE (1 << 18) >> >> +#define DR7_RESET_VALUE 0x400 >> +typedef struct { >> + BOOLEAN Dr7Cached; >> + UINT64 Dr7; >> +} SEV_ES_PER_CPU_DATA; >> + >> typedef enum { >> LongMode64Bit = 0, >> LongModeCompat32Bit, >> @@ -1081,6 +1087,60 @@ RdtscExit ( >> return 0; >> } >> >> +STATIC >> +UINTN >> +Dr7WriteExit ( >> + GHCB *Ghcb, >> + EFI_SYSTEM_CONTEXT_X64 *Regs, >> + SEV_ES_INSTRUCTION_DATA *InstructionData >> + ) >> +{ >> + SEV_ES_INSTRUCTION_OPCODE_EXT *Ext = &InstructionData->Ext; >> + SEV_ES_PER_CPU_DATA *SevEsData = (SEV_ES_PER_CPU_DATA *) (Ghcb >> + 1); >> + INTN *Register; >> + UINTN Status; >> + >> + DecodeModRm (Regs, InstructionData); >> + >> + /* MOV DRn always treats MOD == 3 no matter how encoded */ >> + Register = GetRegisterPointer (Regs, Ext->ModRm.Rm); >> + >> + /* Using a value of 0 for ExitInfo1 means RAX holds the value */ >> + Ghcb->SaveArea.Rax = *Register; >> + GhcbSetRegValid (Ghcb, GhcbRax); >> + >> + Status = VmgExit (Ghcb, SvmExitDr7Write, 0, 0); >> + if (Status) { >> + return Status; >> + } >> + >> + SevEsData->Dr7 = *Register; >> + SevEsData->Dr7Cached = TRUE; >> + >> + return 0; >> +} >> + >> +STATIC >> +UINTN >> +Dr7ReadExit ( >> + GHCB *Ghcb, >> + EFI_SYSTEM_CONTEXT_X64 *Regs, >> + SEV_ES_INSTRUCTION_DATA *InstructionData >> + ) >> +{ >> + SEV_ES_INSTRUCTION_OPCODE_EXT *Ext = &InstructionData->Ext; >> + SEV_ES_PER_CPU_DATA *SevEsData = (SEV_ES_PER_CPU_DATA *) (Ghcb >> + 1); >> + INTN *Register; >> + >> + DecodeModRm (Regs, InstructionData); >> + >> + /* MOV DRn always treats MOD == 3 no matter how encoded */ >> + Register = GetRegisterPointer (Regs, Ext->ModRm.Rm); >> + *Register = (SevEsData->Dr7Cached) ? SevEsData->Dr7 : DR7_RESET_VALUE; >> + >> + return 0; >> +} >> + >> UINTN >> DoVcCommon ( >> GHCB *Ghcb, >> @@ -1097,6 +1157,14 @@ DoVcCommon ( >> >> ExitCode = Regs->ExceptionData; >> switch (ExitCode) { >> + case SvmExitDr7Read: >> + NaeExit = Dr7ReadExit; >> + break; >> + >> + case SvmExitDr7Write: >> + NaeExit = Dr7WriteExit; >> + break; >> + >> case SvmExitRdtsc: >> NaeExit = RdtscExit; >> break; >> diff --git >> a/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ExceptionHandlerAsm.nasm >> b/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ExceptionHandlerAsm.nasm >> index 19198f273137..a0549f7ae6bd 100644 >> --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ExceptionHandlerAsm.nasm >> +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ExceptionHandlerAsm.nasm >> @@ -225,6 +225,9 @@ HasErrorCode: >> push rax >> >> ;; UINT64 Dr0, Dr1, Dr2, Dr3, Dr6, Dr7; >> + cmp qword [rbp + 8], 29 >> + je VcDebugRegs ; For SEV-ES (#VC) Debug registers ignored >> + >> mov rax, dr7 >> push rax >> mov rax, dr6 >> @@ -237,7 +240,19 @@ HasErrorCode: >> push rax >> mov rax, dr0 >> push rax >> + jmp DrFinish >> >> +VcDebugRegs: >> +;; UINT64 Dr0, Dr1, Dr2, Dr3, Dr6, Dr7 are skipped for #VC to avoid >> exception recursion >> + xor rax, rax >> + push rax >> + push rax >> + push rax >> + push rax >> + push rax >> + push rax >> + >> +DrFinish: >> ;; FX_SAVE_STATE_X64 FxSaveState; >> sub rsp, 512 >> mov rdi, rsp >> -- >> 2.17.1 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52177): https://edk2.groups.io/g/devel/message/52177 Mute This Topic: https://groups.io/mt/60973119/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-