Reviewed-by: Michael Kubacki <michael.a.kuba...@intel.com> > -----Original Message----- > From: Agyeman, Prince <prince.agye...@intel.com> > Sent: Wednesday, December 11, 2019 5:13 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel <chasel.c...@intel.com>; Desimone, Nathaniel L > <nathaniel.l.desim...@intel.com>; Kubacki, Michael A > <michael.a.kuba...@intel.com> > Subject: [edk2-platforms] [PATCH] WhiskeylakeOpenBoardPkg: Update PCDs > to enable stack sharing > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2409 > > Updated WhiskeylakeURvp PCDs to enable FSP/BL stack sharing. > This fixes the boot failure seen with the latest Coffee Lake (CFL) FSP binary > (v > 7.0.68.41) > > Cc: Chasel Chiu <chasel.c...@intel.com> > Cc: Nate DeSimone <nathaniel.l.desim...@intel.com> > Cc: Michael Kubacki <michael.a.kuba...@intel.com> > > Signed-off-by: Prince Agyeman <prince.agye...@intel.com> > --- > .../WhiskeylakeURvp/OpenBoardPkgPcd.dsc | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > PkgPcd.dsc > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > PkgPcd.dsc > index 906f7b7ade..b3e1da3970 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > PkgPcd.dsc > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > Pk > +++ gPcd.dsc > @@ -54,15 +54,14 @@ > gSiPkgTokenSpaceGuid.PcdTsegSize|0x1000000 > > # > - # FSP API mode does not share stack with the boot loader, > - # so FSP needs more temporary memory for FSP heap + stack size. > + # When sharing stack with boot loader, FSP only needs small temp ram > + for heap > # > - gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize|0x26000 > + gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize|0x10000 > + > # > - # FSP API mode does not need to enlarge the boot loader stack size > - # since the stacks are separate. > + # Boot loader stack size has to be big enough to executing FSP > # > - gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x20000 > + gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x40000 > > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xE0000000 > gMinPlatformPkgTokenSpaceGuid.PcdPciExpressRegionLength|0x10000000 > -- > 2.19.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52171): https://edk2.groups.io/g/devel/message/52171 Mute This Topic: https://groups.io/mt/68227150/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
