On 11/25/19 10:22 AM, Sami Mujawar via Groups.Io wrote:
The Basetools scripts have been updated to report
warnings if header files are not listed in the
[Sources] section of the inf files.
Update the inf files to include the respective
header files to fix the reported warnings.
Cc: Alexei Fedorov <alexei.fedo...@arm.com>
Signed-off-by: Sami Mujawar <sami.muja...@arm.com>
---
The changes can be seen at:
https://github.com/samimujawar/edk2/tree/686_dynamic_tables_fix_include_warning_v1
Notes:
v2:
- Fixed patch check failure in commit message, [SAMI]
changed 'CC' to 'Cc'. No code change.
Again, already reviewed:
https://www.mail-archive.com/devel@edk2.groups.io/msg11965.html
Reviewed-by: Philippe Mathieu-Daude <phi...@redhat.com>
v1:
- Fix missing header warnings [SAMI]
DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.inf |
1 +
DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibArm.inf |
3 ++-
DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/AcpiPpttLibArm.inf |
1 +
3 files changed, 4 insertions(+), 1 deletion(-)
diff --git
a/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.inf
b/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.inf
index
b47a690dd72702a2d7157cbb21249ba1d01d08cd..920aa81e31b402cae645d919ee6559d8c9bde136
100644
--- a/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.inf
+++ b/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.inf
@@ -23,6 +23,7 @@ [Defines]
[Sources]
AcpiTableFactory/AcpiTableFactory.c
DeviceTreeTableFactory/DeviceTreeTableFactory.c
+ DynamicTableFactory.h
DynamicTableFactoryDxe.c
SmbiosTableFactory/SmbiosTableFactory.c
diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibArm.inf b/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibArm.inf
index
3bbd0e7818c6172f9178b12a3d0960e2d298bca1..2f987e3b6d339d4b5f342cb52b8dc712cf4e585c
100644
--- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibArm.inf
+++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibArm.inf
@@ -1,7 +1,7 @@
## @file
# IORT Table Generator
#
-# Copyright (c) 2017 - 2018, ARM Limited. All rights reserved.
+# Copyright (c) 2017 - 2019, ARM Limited. All rights reserved.
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
@@ -18,6 +18,7 @@ [Defines]
[Sources]
IortGenerator.c
+ IortGenerator.h
[Packages]
MdePkg/MdePkg.dec
diff --git
a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/AcpiPpttLibArm.inf
b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/AcpiPpttLibArm.inf
index
3cb13d7d8fd3df04f3e16cc6161d9736f7579a80..2c7d19513d6ceea29fd9f271f983a6cf6d2c1046
100644
--- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/AcpiPpttLibArm.inf
+++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/AcpiPpttLibArm.inf
@@ -18,6 +18,7 @@ [Defines]
[Sources]
PpttGenerator.c
+ PpttGenerator.h
[Packages]
EmbeddedPkg/EmbeddedPkg.dec
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#51228): https://edk2.groups.io/g/devel/message/51228
Mute This Topic: https://groups.io/mt/61916653/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
