On 8/23/19 12:55 PM, Sami Mujawar wrote:
The Dynamic Tables Factory protocol has an erroneous
EFIAPI calling convention macro in the function
pointer declaration.

Remove the erroneous EFIAPI calling convention macro
from the interface declarations.

Signed-off-by: Sami Mujawar <sami.muja...@arm.com>
---
  DynamicTablesPkg/Include/Protocol/DynamicTableFactoryProtocol.h | 11 
+----------
  1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/DynamicTablesPkg/Include/Protocol/DynamicTableFactoryProtocol.h 
b/DynamicTablesPkg/Include/Protocol/DynamicTableFactoryProtocol.h
index 
d07d0cac36dedb0568f6f604daa22429565aafd3..ff2331b060019976319fc2707f65252130a5326c
 100644
--- a/DynamicTablesPkg/Include/Protocol/DynamicTableFactoryProtocol.h
+++ b/DynamicTablesPkg/Include/Protocol/DynamicTableFactoryProtocol.h
@@ -1,6 +1,6 @@
  /** @file
- Copyright (c) 2017 - 2018, ARM Limited. All rights reserved.
+  Copyright (c) 2017 - 2019, ARM Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -53,7 +53,6 @@ typedef struct DynamicTableFactoryInfo EDKII_DYNAMIC_TABLE_FACTORY_INFO;
  **/
  typedef
  EFI_STATUS
-EFIAPI
  (EFIAPI * EDKII_DYNAMIC_TABLE_FACTORY_GET_ACPI_TABLE_GENERATOR) (
    IN  CONST EDKII_DYNAMIC_TABLE_FACTORY_PROTOCOL  * CONST This,
    IN  CONST ACPI_TABLE_GENERATOR_ID                       GeneratorId,
@@ -73,7 +72,6 @@ EFIAPI
  **/
  typedef
  EFI_STATUS
-EFIAPI
  (EFIAPI * EDKII_DYNAMIC_TABLE_FACTORY_REGISTER_ACPI_TABLE_GENERATOR) (
    IN  CONST ACPI_TABLE_GENERATOR                * CONST Generator
    );
@@ -89,7 +87,6 @@ EFIAPI
  **/
  typedef
  EFI_STATUS
-EFIAPI
  (EFIAPI * EDKII_DYNAMIC_TABLE_FACTORY_DEREGISTER_ACPI_TABLE_GENERATOR) (
    IN  CONST ACPI_TABLE_GENERATOR                * CONST Generator
    );
@@ -109,7 +106,6 @@ EFIAPI
  **/
  typedef
  EFI_STATUS
-EFIAPI
  (EFIAPI * EDKII_DYNAMIC_TABLE_FACTORY_GET_SMBIOS_TABLE_GENERATOR) (
    IN  CONST EDKII_DYNAMIC_TABLE_FACTORY_PROTOCOL  * CONST This,
    IN  CONST SMBIOS_TABLE_GENERATOR_ID                     GeneratorId,
@@ -129,7 +125,6 @@ EFIAPI
  **/
  typedef
  EFI_STATUS
-EFIAPI
  (EFIAPI * EDKII_DYNAMIC_TABLE_FACTORY_REGISTER_SMBIOS_TABLE_GENERATOR) (
    IN  CONST SMBIOS_TABLE_GENERATOR              * CONST Generator
    );
@@ -145,7 +140,6 @@ EFIAPI
  **/
  typedef
  EFI_STATUS
-EFIAPI
  (EFIAPI * EDKII_DYNAMIC_TABLE_FACTORY_DEREGISTER_SMBIOS_TABLE_GENERATOR) (
    IN  CONST SMBIOS_TABLE_GENERATOR              * CONST Generator
    );
@@ -165,7 +159,6 @@ EFIAPI
  **/
  typedef
  EFI_STATUS
-EFIAPI
  (EFIAPI * EDKII_DYNAMIC_TABLE_FACTORY_GET_DT_TABLE_GENERATOR) (
    IN  CONST EDKII_DYNAMIC_TABLE_FACTORY_PROTOCOL  * CONST This,
    IN  CONST DT_TABLE_GENERATOR_ID                         GeneratorId,
@@ -185,7 +178,6 @@ EFIAPI
  **/
  typedef
  EFI_STATUS
-EFIAPI
  (EFIAPI * EDKII_DYNAMIC_TABLE_FACTORY_REGISTER_DT_TABLE_GENERATOR) (
    IN  CONST DT_TABLE_GENERATOR                * CONST Generator
    );
@@ -204,7 +196,6 @@ EFIAPI
  **/
  typedef
  EFI_STATUS
-EFIAPI
  (EFIAPI * EDKII_DYNAMIC_TABLE_FACTORY_DEREGISTER_DT_TABLE_GENERATOR) (
    IN  CONST DT_TABLE_GENERATOR                * CONST Generator
    );


Reviewed-by: Philippe Mathieu-Daude <phi...@redhat.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51078): https://edk2.groups.io/g/devel/message/51078
Mute This Topic: https://groups.io/mt/32999795/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to