The Basetools scripts have been updated to report warnings if header files are not listed in the [Sources] section of the inf files.
Update the inf files to include the respective header files to fix the reported warnings. Signed-off-by: Sami Mujawar <sami.muja...@arm.com> --- The changes can be seen at: https://github.com/samimujawar/edk2/tree/699_armpkg_fix_missing_header_warning_v1 Notes: v1: - Fix missing header warnings [SAMI] ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf | 7 ++++++- ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf | 3 ++- ArmPkg/Filesystem/SemihostFs/SemihostFs.inf | 3 ++- ArmPkg/Library/SemihostLib/SemihostLib.inf | 3 ++- 4 files changed, 12 insertions(+), 4 deletions(-) diff --git a/ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf b/ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf index 6cd3aa1c82ec85cbd5b99402bfac695cfe02a831..06d1a8f957cdd41d7d25d4924e1595a9b360d483 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf +++ b/ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf @@ -1,6 +1,6 @@ #/** @file # -# Copyright (c) 2017-2018, Arm Limited. All rights reserved. +# Copyright (c) 2017 - 2019, Arm Limited. All rights reserved. # # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -18,11 +18,16 @@ [Defines] ENTRY_POINT = ArmScmiDxeEntryPoint [Sources.common] + ArmScmiBaseProtocolPrivate.h + ArmScmiClockProtocolPrivate.h + ArmScmiPerformanceProtocolPrivate.h Scmi.c ScmiBaseProtocol.c ScmiClockProtocol.c ScmiDxe.c + ScmiDxe.h ScmiPerformanceProtocol.c + ScmiPrivate.h [Packages] ArmPkg/ArmPkg.dec diff --git a/ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf b/ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf index d725a2c858398ca0044584a4452506b43e2e8209..7bc128816075595c9af50eef08a2445ce67f788c 100644 --- a/ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf +++ b/ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf @@ -1,5 +1,5 @@ # -# Copyright (c) 2013-2017, ARM Limited. All rights reserved. +# Copyright (c) 2013 - 2019, ARM Limited. All rights reserved. # # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -13,6 +13,7 @@ [Defines] ENTRY_POINT = GenericWatchdogEntry [Sources.common] + GenericWatchdog.h GenericWatchdogDxe.c [Packages] diff --git a/ArmPkg/Filesystem/SemihostFs/SemihostFs.inf b/ArmPkg/Filesystem/SemihostFs/SemihostFs.inf index cd79e18b26cdc0130eb93d8a463934474271d57a..b31354d8a70136e14a4e30b1fdaf5b0655cfd9a9 100644 --- a/ArmPkg/Filesystem/SemihostFs/SemihostFs.inf +++ b/ArmPkg/Filesystem/SemihostFs/SemihostFs.inf @@ -2,7 +2,7 @@ # Support a Semi Host file system over a debuggers JTAG # # Copyright (c) 2009, Apple Inc. All rights reserved.<BR> -# Portions copyright (c) 2011 - 2013, ARM Ltd. All rights reserved. +# Portions copyright (c) 2011 - 2019, ARM Ltd. All rights reserved. # # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -19,6 +19,7 @@ [Defines] [Sources.ARM, Sources.AARCH64] Arm/SemihostFs.c + Arm/SemihostFs.h [Packages] MdePkg/MdePkg.dec diff --git a/ArmPkg/Library/SemihostLib/SemihostLib.inf b/ArmPkg/Library/SemihostLib/SemihostLib.inf index a46618d30eef90b58b42f58c066bfb94941eac36..b94bb888888f73ea7c9a056c56e7c74a859025bb 100644 --- a/ArmPkg/Library/SemihostLib/SemihostLib.inf +++ b/ArmPkg/Library/SemihostLib/SemihostLib.inf @@ -2,7 +2,7 @@ # Semihosting JTAG lib # # Copyright (c) 2008 - 2010, Apple Inc. All rights reserved.<BR> -# Copyright (c) 2011 - 2013, ARM Ltd. All rights reserved.<BR> +# Copyright (c) 2011 - 2019, ARM Ltd. All rights reserved.<BR> # # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -25,6 +25,7 @@ [Defines] # [Sources.common] SemihostLib.c + SemihostPrivate.h [Sources.ARM] Arm/GccSemihost.S | GCC -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#51060): https://edk2.groups.io/g/devel/message/51060 Mute This Topic: https://groups.io/mt/61077885/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-