Reviewed-by: Liming Gao <liming....@intel.com> >-----Original Message----- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Kubacki, Michael A >Sent: Thursday, November 21, 2019 10:33 AM >To: devel@edk2.groups.io >Cc: Gao, Liming <liming....@intel.com>; Kinney, Michael D ><michael.d.kin...@intel.com>; Wang, Jian J <jian.j.w...@intel.com>; Wu, >Hao A <hao.a...@intel.com> >Subject: [edk2-devel] [PATCH V1 1/1] MdeModulePkg/Variable: Initialize local >variable > >REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2364 > >Fixes a new build warning in VS2012 introduced in f8ff4cca7c. > >This patch initializes the local variable "Variable" in >VariableServiceGetNextVariableInternal () and the local >variable "RtPtrTrack" in FindVariableInRuntimeCache (). >This enusres the pointers in the structures are initialized >in the case no variable stores exist in the list of variable >stores. > >Cc: Liming Gao <liming....@intel.com> >Cc: Michael D Kinney <michael.d.kin...@intel.com> >Cc: Jian J Wang <jian.j.w...@intel.com> >Cc: Hao A Wu <hao.a...@intel.com> >Signed-off-by: Michael Kubacki <michael.a.kuba...@intel.com> >--- > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableParsing.c | 2 ++ > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c >| 2 ++ > 2 files changed, 4 insertions(+) > >diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableParsing.c >b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableParsing.c >index d458f1c608..f6d187543d 100644 >--- a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableParsing.c >+++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableParsing.c >@@ -551,6 +551,8 @@ VariableServiceGetNextVariableInternal ( > return EFI_INVALID_PARAMETER; > } > >+ ZeroMem (&Variable, sizeof (Variable)); >+ > // Check if the variable exists in the given variable store list > for (StoreType = (VARIABLE_STORE_TYPE) 0; StoreType < >VariableStoreTypeMax; StoreType++) { > if (VariableStoreList[StoreType] == NULL) { >diff --git >a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe >.c >b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDx >e.c >index d525998ae3..2cf0ed32ae 100644 >--- >a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe >.c >+++ >b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDx >e.c >@@ -590,6 +590,8 @@ FindVariableInRuntimeCache ( > return EFI_INVALID_PARAMETER; > } > >+ ZeroMem (&RtPtrTrack, sizeof (RtPtrTrack)); >+ > // > // The UEFI specification restricts Runtime Services callers from invoking > the >same or certain other Runtime Service > // functions prior to completion and return from a previous Runtime Service >call. These restrictions prevent >-- >2.16.2.windows.1 > > >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#50991): https://edk2.groups.io/g/devel/message/50991 Mute This Topic: https://groups.io/mt/60998486/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
