Reviewed-by: Sai Chaganty <rangasai.v.chaga...@intel.com>
-----Original Message-----
From: Desimone, Nathaniel L
Sent: Wednesday, November 13, 2019 10:07 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.c...@intel.com>; Kubacki, Michael A
<michael.a.kuba...@intel.com>; Chaganty, Rangasai V
<rangasai.v.chaga...@intel.com>
Subject: [edk2-platforms] [PATCH V1 01/13] KabylakeSiliconPkg: Change
MODULE_TYPE of SiliconInitLib to PEIM
This library contains PEI phase only code. For example,
ClearIchSmiAndWake() calls PeiServicesGetBootMode().
Accordingly, this library should have never been marked as a BASE library.
Cc: Chasel Chiu <chasel.c...@intel.com>
Cc: Michael Kubacki <michael.a.kuba...@intel.com>
Cc: Sai Chaganty <rangasai.v.chaga...@intel.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desim...@intel.com>
---
.../PeiSiliconInitLib.inf} | 3 ++-
.../{SiliconInitLib => PeiSiliconInitLib}/SiliconInit.c | 0
.../{SiliconInitLib => PeiSiliconInitLib}/SiliconInitPreMem.c | 0
3 files changed, 2 insertions(+), 1 deletion(-) rename
Silicon/Intel/KabylakeSiliconPkg/Library/{SiliconInitLib/SiliconInitLib.inf =>
PeiSiliconInitLib/PeiSiliconInitLib.inf} (91%) rename
Silicon/Intel/KabylakeSiliconPkg/Library/{SiliconInitLib =>
PeiSiliconInitLib}/SiliconInit.c (100%) rename
Silicon/Intel/KabylakeSiliconPkg/Library/{SiliconInitLib =>
PeiSiliconInitLib}/SiliconInitPreMem.c (100%)
diff --git
a/Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInitLib.inf
b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/PeiSiliconInitLib.inf
similarity index 91%
rename from
Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInitLib.inf
rename to
Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/PeiSiliconInitLib.inf
index 132080e876..ff83bf2835 100644
--- a/Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInitLib.inf
+++ b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/PeiSili
+++ conInitLib.inf
@@ -11,8 +11,9 @@
BASE_NAME = SiliconInitLib FILE_GUID
= 72CD3A7B-FEA5-4F5E-9165-4DD12187BB13 VERSION_STRING =
1.0- MODULE_TYPE = BASE+ MODULE_TYPE =
PEIM LIBRARY_CLASS = SiliconInitLib+ # # The following
information is for reference only and not required by the build tools. #diff
--git a/Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInit.c
b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInit.c
similarity index 100%
rename from
Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInit.c
rename to
Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInit.c
diff --git
a/Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInitPreMem.c
b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInitPreMem.c
similarity index 100%
rename from
Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInitPreMem.c
rename to
Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInitPreMem.c
--
2.23.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#50723): https://edk2.groups.io/g/devel/message/50723
Mute This Topic: https://groups.io/mt/57059572/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
