This patch looks good. Reviewed-by: Bob C Feng <[email protected]>
-----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Ni, Ray Sent: Tuesday, November 12, 2019 2:18 PM To: [email protected] Cc: Feng, Bob C <[email protected]>; Gao, Liming <[email protected]> Subject: [edk2-devel] [PATCH] BaseTools: Fix build failure when using python38 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2304 Signed-off-by: Ray Ni <[email protected]> Cc: Bob C Feng <[email protected]> Cc: Liming Gao <[email protected]> --- BaseTools/Source/Python/build/build.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Python/build/build.py index bcd832c525..6c8798ef93 100755 --- a/BaseTools/Source/Python/build/build.py +++ b/BaseTools/Source/Python/build/build.py @@ -2064,7 +2064,7 @@ class Build(): if Fdf.CurrentFdName and Fdf.CurrentFdName in Fdf.Profile.FdDict: FdDict = Fdf.Profile.FdDict[Fdf.CurrentFdName] for FdRegion in FdDict.RegionList: - if str(FdRegion.RegionType) is 'FILE' and self.Platform.VpdToolGuid in str(FdRegion.RegionDataList): + if str(FdRegion.RegionType) == 'FILE' and self.Platform.VpdToolGuid in str(FdRegion.RegionDataList): if int(FdRegion.Offset) % 8 != 0: EdkLogger.error("build", FORMAT_INVALID, 'The VPD Base Address %s must be 8-byte aligned.' % (FdRegion.Offset)) Wa.FdfProfile = Fdf.Profile -- 2.21.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#50441): https://edk2.groups.io/g/devel/message/50441 Mute This Topic: https://groups.io/mt/54042169/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
