On 11/11/19 17:35, Kinney, Michael D wrote: > Hi Laszlo, > > I will change to pip-requirements.txt.
Please update both the subject line and the actual filename. With that: Reviewed-by: Laszlo Ersek <ler...@redhat.com> Thanks! Laszlo > > Mike > >> -----Original Message----- >> From: Laszlo Ersek <ler...@redhat.com> >> Sent: Monday, November 11, 2019 1:58 AM >> To: Kinney, Michael D <michael.d.kin...@intel.com>; >> devel@edk2.groups.io >> Cc: Sean Brogan <sean.bro...@microsoft.com>; Andrew Fish >> <af...@apple.com>; Leif Lindholm >> <leif.lindh...@linaro.org>; Gao, Liming >> <liming....@intel.com> >> Subject: Re: [Patch v5 03/22] pip_requirements.txt: Add >> python pip requirements file >> >> Hi Mike, >> >> On 11/11/19 09:40, Michael D Kinney wrote: >>> From: Sean Brogan <sean.bro...@microsoft.com> >>> >>> Add pip requirements file that is used to install the >> python pip >>> modules build from the edk2-pytool-library and edk2- >> pytool-extensions >>> repositories. >>> >>> These python modules provide the extensions required >> to perform EDK II >>> Continuous Integration(CI) builds. >>> >>> Cc: Andrew Fish <af...@apple.com> >>> Cc: Laszlo Ersek <ler...@redhat.com> >>> Cc: Leif Lindholm <leif.lindh...@linaro.org> >>> Signed-off-by: Michael D Kinney >> <michael.d.kin...@intel.com> >>> Reviewed-by: Liming Gao <liming....@intel.com> >>> --- >>> pip_requirements.txt | 17 +++++++++++++++++ >>> 1 file changed, 17 insertions(+) >>> create mode 100644 pip_requirements.txt >>> >>> diff --git a/pip_requirements.txt >> b/pip_requirements.txt new file mode >>> 100644 index 0000000000..4ad72cfc98 >>> --- /dev/null >>> +++ b/pip_requirements.txt >> >> Is the underscore (ASCII 0x5F) a typo / >> misunderstanding, or is it >> intentional? >> >> I never tested "pip_requirements.txt"; I tested "pip- >> requirements.txt" >> (hyphen, ASCII 0x2D). >> >> Thanks >> Laszlo >> >>> @@ -0,0 +1,17 @@ >>> +## @file >>> +# EDK II Python PIP requirements file >>> +# >>> +# This file provides the list of python components to >> install using PIP. >>> +# >>> +# Copyright (c) Microsoft Corporation. All rights >> reserved.<BR> >>> +# >>> +# SPDX-License-Identifier: BSD-2-Clause-Patent >>> +# >>> +# https://pypi.org/project/pip/ >>> +# >> https://pip.pypa.io/en/stable/user_guide/#requirements- >> files >>> +# >> https://pip.pypa.io/en/stable/reference/pip_install/#req >> uirements-file-format >>> +# >>> +## >>> + >>> +edk2-pytool-library==0.10.* >>> +edk2-pytool-extensions==0.12.* >>> > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#50374): https://edk2.groups.io/g/devel/message/50374 Mute This Topic: https://groups.io/mt/52458143/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
