Reviewed-by: Nate DeSimone <nathaniel.l.desim...@intel.com>
-----Original Message-----
From: Desimone, Ashley E <ashley.e.desim...@intel.com>
Sent: Wednesday, November 6, 2019 2:40 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desim...@intel.com>; Pandya, Puja
<puja.pan...@intel.com>
Subject: [edk2-devel][edk2-staging/EdkRepo][PATCH v2 8/8] EdkRepo: Argument
Strings Refactor - EdkRepo Command
Move all argument strings for edkrepo_command.py to
edkrepo/commands/arguments/edkrepo_cmd_args.py
Signed-off-by: Ashley E Desimone <ashley.e.desim...@intel.com>
Cc: Nate DeSimone <nathaniel.l.desim...@intel.com>
Cc: Puja Pandya <puja.pan...@intel.com>
---
.../arguments/edkrepo_cmd_args.py} | 9 +++------
edkrepo/commands/edkrepo_command.py | 16 ++++++----------
2 files changed, 9 insertions(+), 16 deletions(-) rename
edkrepo/{common/argument_strings.py => commands/arguments/edkrepo_cmd_args.py}
(65%)
diff --git a/edkrepo/common/argument_strings.py
b/edkrepo/commands/arguments/edkrepo_cmd_args.py
similarity index 65%
rename from edkrepo/common/argument_strings.py
rename to edkrepo/commands/arguments/edkrepo_cmd_args.py
index 75e13ee..f2d7eb6 100644
--- a/edkrepo/common/argument_strings.py
+++ b/edkrepo/commands/arguments/edkrepo_cmd_args.py
@@ -7,15 +7,12 @@
# SPDX-License-Identifier: BSD-2-Clause-Patent #
-'''Contains help and description strings for arguments in command meta data.'''
+'''Contains help and description strings for arguments in the
+edkrepo_command meta data.
+'''
-#Args for edk_command.py
-VERBOSE_DESCRIPTION = 'Enable verbose output'
VERBOSE_HELP = 'Increases command verbosity'
-DRY_RUN_DESCRIPTION = "Don't actually do anything"
DRY_RUN_HELP = "Don't actually do anything"
OVERRIDE_HELP = 'Ignore warnings'
SUBMODULE_SKIP_HELP = 'Skip the pull or sync of any submodules.'
COLOR_HELP = 'Force color output (useful with \'less -r\')'
-
-
diff --git a/edkrepo/commands/edkrepo_command.py
b/edkrepo/commands/edkrepo_command.py
index 75b6f35..f69bdb8 100644
--- a/edkrepo/commands/edkrepo_command.py
+++ b/edkrepo/commands/edkrepo_command.py
@@ -7,9 +7,7 @@
# SPDX-License-Identifier: BSD-2-Clause-Patent #
-# Our modules
-from edkrepo.common.argument_strings import VERBOSE_DESCRIPTION, VERBOSE_HELP,
DRY_RUN_DESCRIPTION, DRY_RUN_HELP, COLOR_HELP -from
edkrepo.common.argument_strings import OVERRIDE_HELP, SUBMODULE_SKIP_HELP
+import edkrepo.commands.arguments.edkrepo_cmd_args as arguments
class EdkrepoCommand(object):
@@ -25,30 +23,28 @@ VerboseArgument = {'name': 'verbose',
'short-name': 'v',
'positional': False,
'required': False,
- 'description': VERBOSE_DESCRIPTION ,
- 'help-text': VERBOSE_HELP}
+ 'help-text': arguments.VERBOSE_HELP}
DryRunArgument = {'name': 'dry-run',
'positional': False,
'required': False,
- 'description': DRY_RUN_DESCRIPTION,
- 'help-text': DRY_RUN_HELP}
+ 'help-text': arguments.DRY_RUN_HELP}
OverrideArgument = {'name': 'override',
'short-name': 'o',
'positional': False,
'required': False,
- 'help-text': OVERRIDE_HELP}
+ 'help-text': arguments.OVERRIDE_HELP}
ColorArgument = {'name' : 'color',
'short-name': 'c',
'positional' : False,
'required' : False,
- 'help-text' : COLOR_HELP}
+ 'help-text' : arguments.COLOR_HELP}
SubmoduleSkipArgument = {'name': 'skip-submodule',
'short-name' : 's',
'positional' : False,
'required' : False,
- 'help-text' : SUBMODULE_SKIP_HELP}
+ 'help-text' : arguments.SUBMODULE_SKIP_HELP}
--
2.16.2.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#50099): https://edk2.groups.io/g/devel/message/50099
Mute This Topic: https://groups.io/mt/44653257/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
