Exactly. The #2 should be updated. Thanks, Zhichao
> -----Original Message----- > From: Gao, Liming > Sent: Monday, November 4, 2019 11:27 AM > To: Gao, Zhichao <zhichao....@intel.com>; Sudipto Paul > <sudipto.p...@arm.com>; Sami Mujawar <sami.muja...@arm.com>; > Krzysztof Koch <krzysztof.k...@arm.com>; devel@edk2.groups.io > Cc: Carsey, Jaben <jaben.car...@intel.com>; Ni, Ray <ray...@intel.com>; > Kinney, Michael D <michael.d.kin...@intel.com>; Matteo Carlini > <matteo.carl...@arm.com>; nd <n...@arm.com>; Deepak Pandey > <deepak.pan...@arm.com> > Subject: RE: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3 > > I see the change in MdePkg has been pushed. So, the remaining discussion is > about the change in ShellPkg, right? > > Thanks > Liming > >-----Original Message----- > >From: Gao, Zhichao > >Sent: Monday, November 04, 2019 10:13 AM > >To: Sudipto Paul <sudipto.p...@arm.com>; Sami Mujawar > ><sami.muja...@arm.com>; Krzysztof Koch <krzysztof.k...@arm.com>; > >devel@edk2.groups.io > >Cc: Carsey, Jaben <jaben.car...@intel.com>; Ni, Ray <ray...@intel.com>; > >Kinney, Michael D <michael.d.kin...@intel.com>; Gao, Liming > ><liming....@intel.com>; Matteo Carlini <matteo.carl...@arm.com>; nd > ><n...@arm.com>; Deepak Pandey <deepak.pan...@arm.com> > >Subject: RE: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3 > > > >Thanks for the T-B. > >But the patch has conflict now, can you help to address it? As I know > >the previous change aims to remove the declaration of the internal used > function. > >So I suggest to remove the declaration of the new added function and > >move the definition to the location of the declaration. > > > >Thanks, > >Zhichao > > > >> -----Original Message----- > >> From: Sudipto Paul <sudipto.p...@arm.com> > >> Sent: Friday, November 1, 2019 9:59 PM > >> To: Sami Mujawar <sami.muja...@arm.com>; Krzysztof Koch > >> <krzysztof.k...@arm.com>; devel@edk2.groups.io > >> Cc: Carsey, Jaben <jaben.car...@intel.com>; Ni, Ray > >> <ray...@intel.com>; > >Gao, > >> Zhichao <zhichao....@intel.com>; Kinney, Michael D > >> <michael.d.kin...@intel.com>; Gao, Liming <liming....@intel.com>; > >Matteo > >> Carlini <matteo.carl...@arm.com>; nd <n...@arm.com>; Deepak Pandey > >> <deepak.pan...@arm.com> > >> Subject: RE: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI > >> 6.3 > >> > >> Tested-by: Sudipto Paul <sudipto.p...@arm.com > >> > >> This patch has been tested on N1SDP. This is a public Neoverse > >> branded > >cores > >> System Development Platform. > >> https://community.arm.com/developer/tools-software/oss- > >> platforms/w/docs/440/neoverse-n1-sdp > >> > >> > >> -Sudipto > >> > >> -----Original Message----- > >> From: Sami Mujawar <sami.muja...@arm.com> > >> Sent: 21 October 2019 17:06 > >> To: Krzysztof Koch <krzysztof.k...@arm.com>; devel@edk2.groups.io > >> Cc: jaben.car...@intel.com; ray...@intel.com; zhichao....@intel.com; > >> michael.d.kin...@intel.com; liming....@intel.com; Matteo Carlini > >> <matteo.carl...@arm.com>; nd <n...@arm.com>; Deepak Pandey > >> <deepak.pan...@arm.com>; Sudipto Paul <sudipto.p...@arm.com> > >> Subject: RE: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI > >> 6.3 > >> > >> Reviewed-by: Sami Mujawar <sami.muja...@arm.com> > >> > >> Regards, > >> > >> Sami Mujawar > >> > >> -----Original Message----- > >> From: Krzysztof Koch <krzysztof.k...@arm.com> > >> Sent: 12 June 2019 03:10 PM > >> To: devel@edk2.groups.io > >> Cc: jaben.car...@intel.com; ray...@intel.com; zhichao....@intel.com; > >> michael.d.kin...@intel.com; liming....@intel.com; Sami Mujawar > >> <sami.muja...@arm.com>; Matteo Carlini <matteo.carl...@arm.com>; > >> Stephanie Hughes-Fitt <stephanie.hughes-f...@arm.com>; nd > ><n...@arm.com> > >> Subject: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3 > >> > >> This patch adds a number of definitions to the ACPI 6.3 header file > >> for the purpose of parsing Revision 3 of the System Resource Affinity > >> Table > >> (SRAT) in the Acpiview UEFI shell tool. > >> > >> By defining the Generic Initiator Affinity Structure's Type ID and > >> the allowed Device Handle Types for the structure, it is possible to > >> dump and validate > >the > >> contents of the latest version of the SRAT table in acpiview. > >> > >> References: > >> - ACPI 6.3 January 2019, Section 5.2.16.6 > >> > >> Changes can be seen at: > >> > https://github.com/KrzysztofKoch1/edk2/tree/582_acpiview_6_3_srat_v1 > >> > >> Krzysztof Koch (2): > >> MdePkg: Add Generic Initiator Affinity Structure definitions to SRAT > >> ShellPkg: acpiview: Update SRAT parser to ACPI 6.3 > >> > >> MdePkg/Include/IndustryStandard/Acpi63.h | > >> 11 +- > >> ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | > >> 35 > >++- > >> ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h | > >> 16 > >++ > >> > >> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser. > >> c > >| > >> 256 +++++++++++++++++++- > >> 4 files changed, 309 insertions(+), 9 deletions(-) > >> > >> -- > >> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > >> > >> > >> > >> IMPORTANT NOTICE: The contents of this email and any attachments are > >> confidential and may also be privileged. If you are not the intended > >> recipient, please notify the sender immediately and do not disclose > >> the contents to > >any > >> other person, use it for any purpose, or store or copy the > >> information in any medium. Thank you. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49906): https://edk2.groups.io/g/devel/message/49906 Mute This Topic: https://groups.io/mt/32042460/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
