Acked-by: Bob Feng <bob.c.f...@intel.com>
-----Original Message----- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Vitaly Cheptsov via Groups.Io Sent: Sunday, October 20, 2019 6:26 PM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH v1 1/1] BaseTools: Do not call sys.setdefaultencoding with python 3 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2301 This interface was a originally a no-op in python 3, and now is fully removed causing a build warning on macOS (Darwin). Signed-off-by: Vitaly Cheptsov <vit9...@protonmail.com>> --- BaseTools/Source/Python/sitecustomize.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/sitecustomize.py b/BaseTools/Source/Python/sitecustomize.py index 7dbbf8a232..50783e1b3a 100644 --- a/BaseTools/Source/Python/sitecustomize.py +++ b/BaseTools/Source/Python/sitecustomize.py @@ -7,7 +7,7 @@ import sys import locale -if sys.platform == "darwin": +if sys.platform == "darwin" and sys.version_info[0] < 3: DefaultLocal = locale.getdefaultlocale()[1] if DefaultLocal is None: DefaultLocal = 'UTF8' -- 2.21.0 (Apple Git-122) -=-=-=-=-=-= Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49253): https://edk2.groups.io/g/devel/message/49253 Mute This Topic: https://groups.io/mt/35942396/1768742 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [bob.c.f...@intel.com] -=-=-=-=-=-= -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49264): https://edk2.groups.io/g/devel/message/49264 Mute This Topic: https://groups.io/mt/35942396/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-