On 2019.10.16 14:24, Leif Lindholm wrote:
On Wed, Oct 16, 2019 at 01:56:15PM +0200, Philippe Mathieu-Daudé wrote:
On 10/16/19 1:43 PM, Pete Batard wrote:
DEBUG_WARNING was invalid. DEBUG_WARN is the proper channel name to use.
Oops.
+1
Yeah, my bad here.
I was under the impression that PatchCheck would report those, so I
didn't pay enough attention to the debug facility name. And I also only
built RELEASE when validating the new patchset that added this new feature.
Lesson learned. ;)
If anything, this makes a good case for CI, as I picked this issue
through the semi-automated builds I carry out for the Rpi3 firmware [1].
Regards,
/Pete
[1] https://github.com/pbatard/RPi3
Reviewed-by: Philippe Mathieu-Daude <phi...@redhat.com>
And
Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org>
Pushed as bd26e4137525.
Thanks Pete.
/
Leif
Signed-off-by: Pete Batard <p...@akeo.ie>
---
Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 2
+-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c
b/Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c
index 5abc82b8d363..c72a749b6a2a 100644
--- a/Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c
+++ b/Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c
@@ -874,7 +874,7 @@ MemArrMapInfoUpdateSmbiosType19 (
mMemArrMapInfoType19.EndingAddress = 256 * 1024;
Status = mFwProtocol->GetModelRevision (&BoardRevision);
if (Status != EFI_SUCCESS) {
- DEBUG ((DEBUG_WARNING, "Couldn't get the board memory size - defaulting to 256
MB: %r\n", Status));
+ DEBUG ((DEBUG_WARN, "Couldn't get the board memory size - defaulting to 256 MB:
%r\n", Status));
} else {
//
www.raspberrypi.org/documentation/hardware/raspberrypi/revision-codes/README.md
// Bits [20-22] indicate the amount of memory starting with 256MB (000b)
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#49102): https://edk2.groups.io/g/devel/message/49102
Mute This Topic: https://groups.io/mt/34559236/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
