Laszlo, > -----Original Message----- > From: Laszlo Ersek <ler...@redhat.com> > Sent: Thursday, October 10, 2019 3:39 PM > To: Ni, Ray <ray...@intel.com>; Dong, Eric <eric.d...@intel.com>; > devel@edk2.groups.io > Cc: Igor Mammedov <imamm...@redhat.com> > Subject: Re: [edk2-devel] [PATCH 1/4] UefiCpuPkg/MpInitLib: honor the > platform's boot CPU count in AP detection > > On 10/10/19 04:52, Ni, Ray wrote: > > Laszlo, > > Can you add comments in the code you changed to describe the two > different behaviors? > > It's described in the DEC file, near the PCD: > > + # nonzero - PcdCpuApInitTimeOutInMicroSeconds is ignored. The > initial > + # AP detection finishes when the detected CPU count (BSP > + # plus APs) reaches the value of this PCD.<BR> > > (1) Do you want me to repeat this explanation in the code as well? Yes, please😊
> > (2) Do you want me to emphasize in the explanation that, if at least one > processor fails to check in, the boot is going to block forever, by design? Yes, please😊. > > (3) Emphasize this in the DEC file only, in the code only, or in both? Code and DEC please. > > Thanks > Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#48708): https://edk2.groups.io/g/devel/message/48708 Mute This Topic: https://groups.io/mt/34441228/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
