Reviewed-by: Chasel Chiu <chasel.c...@intel.com>
> -----Original Message----- > From: Kubacki, Michael A <michael.a.kuba...@intel.com> > Sent: Tuesday, October 8, 2019 1:17 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V <rangasai.v.chaga...@intel.com>; Chiu, Chasel > <chasel.c...@intel.com> > Subject: [edk2-platforms][PATCH V1 02/17] KabylakeSiliconPkg: Add DSC > include file section tags > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2245 > > The DSC LibraryClass files in KabylakeSiliconPkg that are intended to be > included elsewhere such as SiPkgPeiLib.dsc, SiPkgDxeLib.dsc, and > SiPkgCommonLib.dsc should have section tags so that they are not > dependent on the top-level DSC file to place the include file in the correct > location in the DSC file and better define the applicability of their library > content. > > This change adds section tags for the library class related files. > The component files may be built differently in the consuming package > depending on their architecture requirements so those are not modified. > > Cc: Sai Chaganty <rangasai.v.chaga...@intel.com> > Cc: Chasel Chiu <chasel.c...@intel.com> > Signed-off-by: Michael Kubacki <michael.a.kuba...@intel.com> > --- > Silicon/Intel/KabylakeSiliconPkg/SiPkgCommonLib.dsc | 6 ++++-- > Silicon/Intel/KabylakeSiliconPkg/SiPkgDxeLib.dsc | 5 +++-- > Silicon/Intel/KabylakeSiliconPkg/SiPkgPeiLib.dsc | 3 ++- > 3 files changed, 9 insertions(+), 5 deletions(-) > > diff --git a/Silicon/Intel/KabylakeSiliconPkg/SiPkgCommonLib.dsc > b/Silicon/Intel/KabylakeSiliconPkg/SiPkgCommonLib.dsc > index 920b02e410..fa9dd4a32d 100644 > --- a/Silicon/Intel/KabylakeSiliconPkg/SiPkgCommonLib.dsc > +++ b/Silicon/Intel/KabylakeSiliconPkg/SiPkgCommonLib.dsc > @@ -1,11 +1,13 @@ > ## @file > -# Component description file for the SkyLake SiPkg both Pei and Dxe > libraries DSC file. > +# Build description file for Kaby Lake silicon PEI and DXE libraries. > # > -# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR> > +# Copyright (c) 2017 - 2019, Intel Corporation. All rights > +reserved.<BR> > # > # SPDX-License-Identifier: BSD-2-Clause-Patent # ## > + > +[LibraryClasses.common] > # > # Silicon Init Common Library > # > diff --git a/Silicon/Intel/KabylakeSiliconPkg/SiPkgDxeLib.dsc > b/Silicon/Intel/KabylakeSiliconPkg/SiPkgDxeLib.dsc > index 8c194d8e7c..bc497c3531 100644 > --- a/Silicon/Intel/KabylakeSiliconPkg/SiPkgDxeLib.dsc > +++ b/Silicon/Intel/KabylakeSiliconPkg/SiPkgDxeLib.dsc > @@ -1,12 +1,13 @@ > # @file > -# Component description file for the SkyLake SiPkg DXE libraries. > +# Build description file for Kaby Lake silicon DXE libraries. > # > -# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR> > +# Copyright (c) 2017 - 2019, Intel Corporation. All rights > +reserved.<BR> > # > # SPDX-License-Identifier: BSD-2-Clause-Patent # ## > > +[LibraryClasses.common.DXE_CORE,LibraryClasses.common.DXE_SMM_DRIV > ER,Li > +braryClasses.common.SMM_CORE,LibraryClasses.common.DXE_DRIVER,Libr > aryCl > +asses.common.DXE_RUNTIME_DRIVER,LibraryClasses.common.UEFI_DRIVER > ] > # > # Silicon Init Dxe Library > # > diff --git a/Silicon/Intel/KabylakeSiliconPkg/SiPkgPeiLib.dsc > b/Silicon/Intel/KabylakeSiliconPkg/SiPkgPeiLib.dsc > index 86e34ff359..5334598544 100644 > --- a/Silicon/Intel/KabylakeSiliconPkg/SiPkgPeiLib.dsc > +++ b/Silicon/Intel/KabylakeSiliconPkg/SiPkgPeiLib.dsc > @@ -1,5 +1,5 @@ > ## @file > -# Component description file for the SkyLake SiPkg PEI libraries. > +# Build description file for Kaby Lake silicon PEI libraries. > # > # Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR> # > @@ -7,6 +7,7 @@ # ## > > +[LibraryClasses] > # > # Silicon Init Pei Library > # > -- > 2.16.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#48590): https://edk2.groups.io/g/devel/message/48590 Mute This Topic: https://groups.io/mt/34439437/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
