On Tue, 2019-10-01 at 01:21 +0200, Laszlo Ersek wrote: > On 09/29/19 08:09, Wang, Jian J wrote: > > For this patch series, > > 1. " Contributed-under: TianoCore Contribution Agreement 1.1" is not needed > > any more. > > Remove it at push time and no need to send a v2. > > 2. Since it's security patch which had been reviewed separately, I see no > > reason for new r-b > > required. Please raise it asap if any objections. > > 3. Acked-by: Jian J Wang <jian.j.w...@intel.com> > > > * Can you please confirm that these patches match those that we > discussed here: > > https://bugzilla.tianocore.org/show_bug.cgi?id=960#c18 > https://bugzilla.tianocore.org/show_bug.cgi?id=960#c19 > > > * In the BZ, David and Bret raised some questions: > > https://bugzilla.tianocore.org/show_bug.cgi?id=960#c31 > https://bugzilla.tianocore.org/show_bug.cgi?id=960#c32 > https://bugzilla.tianocore.org/show_bug.cgi?id=960#c35 > https://bugzilla.tianocore.org/show_bug.cgi?id=960#c36 > > and > > https://bugzilla.tianocore.org/show_bug.cgi?id=960#c40 > > The latest comment in the bug is c#41. I'm not under the impression that > all concerns raised by David and Bret have been addressed (or > abandoned). I'd like David and Bret to ACK the patches.
I do not believe my comment #35 has been addressed, nor the requested testing performed. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#48340): https://edk2.groups.io/g/devel/message/48340 Mute This Topic: https://groups.io/mt/34307578/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
smime.p7s
Description: S/MIME cryptographic signature