On Tue, 17 Sep 2019 at 21:50, Laszlo Ersek <[email protected]> wrote: > > The SignalEvent() boot service takes an EFI_EVENT, not an (EFI_EVENT*). > Fix the call in the notification function of > "EFI_SIMPLE_NETWORK_PROTOCOL.WaitForPacket". > > This is an actual bug. The reason it's never been triggered is likely that > the "SNP.WaitForPacket" event is rarely waited for by applications -- edk2 > itself has zero instances of that, for example. > > Cc: Ard Biesheuvel <[email protected]> > Cc: Jordan Justen <[email protected]> > Signed-off-by: Laszlo Ersek <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]> > --- > > Notes: > build-tested only > > OvmfPkg/VirtioNetDxe/Events.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/OvmfPkg/VirtioNetDxe/Events.c b/OvmfPkg/VirtioNetDxe/Events.c > index 620910774bc5..83e96e5e5d91 100644 > --- a/OvmfPkg/VirtioNetDxe/Events.c > +++ b/OvmfPkg/VirtioNetDxe/Events.c > @@ -58,7 +58,7 @@ VirtioNetIsPacketAvailable ( > MemoryFence (); > > if (Dev->RxLastUsed != RxCurUsed) { > - gBS->SignalEvent (&Dev->Snp.WaitForPacket); > + gBS->SignalEvent (Dev->Snp.WaitForPacket); > } > } > > -- > 2.19.1.3.g30247aa5d201 > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#48101): https://edk2.groups.io/g/devel/message/48101 Mute This Topic: https://groups.io/mt/34180224/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
